COO intersection primitives: performance improvement#92976
Closed
nikitaved wants to merge 58 commits intogh/nikitaved/16/basefrom
Closed
COO intersection primitives: performance improvement#92976nikitaved wants to merge 58 commits intogh/nikitaved/16/basefrom
nikitaved wants to merge 58 commits intogh/nikitaved/16/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92976
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2b4760a: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jan 25, 2023
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
cpuhrsch
reviewed
Jan 30, 2023
This PR improves COO intersection primitives by: * making it sync-less (dims <= 8, can be changed to any value that fits stack). * improving performance with much less kernel calls. [ghstack-poisoned]
This PR improves COO intersection primitives by: * making it sync-less (dims <= 8, can be changed to any value that fits stack). * improving performance with much less kernel calls. [ghstack-poisoned]
This PR improves COO intersection primitives by: * making it sync-less (dims <= 8, can be changed to any value that fits stack). * improving performance with much less kernel calls. [ghstack-poisoned]
This PR improves COO intersection primitives by: * making it sync-less (dims <= 8, can be changed to any value that fits stack). * improving performance with much less kernel calls. [ghstack-poisoned]
This PR improves COO intersection primitives by: * making it sync-less (dims <= 8, can be changed to any value that fits stack). * improving performance with much less kernel calls. [ghstack-poisoned]
This PR improves COO intersection primitives by: * making it sync-less (dims <= 8, can be changed to any value that fits stack). * improving performance with much less kernel calls. [ghstack-poisoned]
This PR improves COO intersection primitives by: * making it sync-less (dims <= 8, can be changed to any value that fits stack). * improving performance with much less kernel calls. [ghstack-poisoned]
This PR improves COO intersection primitives by: * making it sync-less (dims <= 8, can be changed to any value that fits stack). * improving performance with much less kernel calls. [ghstack-poisoned]
This PR improves COO intersection primitives by: * making it sync-less (dims <= 8, can be changed to any value that fits stack). * improving performance with much less kernel calls. [ghstack-poisoned]
Collaborator
Author
|
@pytorchbot merge -g |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Member
|
@pytorchbot revert -c ghfirst -m "Need to revert this so I can revert #94048 cleanly" |
1 similar comment
Member
|
@pytorchbot revert -c ghfirst -m "Need to revert this so I can revert #94048 cleanly" |
Collaborator
|
@pytorchbot successfully started a revert job. Check the current status here. |
Collaborator
|
@nikitaved your PR has been successfully reverted. |
pytorchmergebot
added a commit
that referenced
this pull request
Mar 3, 2023
This reverts commit b033594. Reverted #92976 on behalf of https://github.com/seemethere due to Need to revert this so I can revert #94048 cleanly
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
This PR improves COO intersection primitives by: * making it sync-less (dims <= 8, can be changed to any value that fits stack). * improving performance with much less kernel calls. Pull Request resolved: pytorch/pytorch#92976 Approved by: https://github.com/cpuhrsch, https://github.com/pearu
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
This reverts commit b033594. Reverted pytorch/pytorch#92976 on behalf of https://github.com/seemethere due to Need to revert this so I can revert pytorch/pytorch#94048 cleanly
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
This PR improves COO intersection primitives by: * making it sync-less (dims <= 8, can be changed to any value that fits stack). * improving performance with much less kernel calls. Pull Request resolved: pytorch/pytorch#92976 Approved by: https://github.com/cpuhrsch, https://github.com/pearu
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
This reverts commit b033594. Reverted pytorch/pytorch#92976 on behalf of https://github.com/seemethere due to Need to revert this so I can revert pytorch/pytorch#94048 cleanly
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
…#92976)" This reverts commit b033594. Reverted pytorch#92976 on behalf of https://github.com/seemethere due to Need to revert this so I can revert pytorch#94048 cleanly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR improves COO intersection primitives by: