Skip to content

reland "Do not use unsafe restriding for subclasses (#87610)"#88343

Closed
bdhirsh wants to merge 7 commits intogh/bdhirsh/341/basefrom
gh/bdhirsh/341/head
Closed

reland "Do not use unsafe restriding for subclasses (#87610)"#88343
bdhirsh wants to merge 7 commits intogh/bdhirsh/341/basefrom
gh/bdhirsh/341/head

Conversation

@bdhirsh
Copy link
Collaborator

@bdhirsh bdhirsh commented Nov 2, 2022

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 2, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88343

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 80f0d71:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@albanD albanD removed their request for review November 2, 2022 19:14
@bdhirsh bdhirsh added the release notes: composability release notes category label Nov 3, 2022
@bdhirsh
Copy link
Collaborator Author

bdhirsh commented Nov 4, 2022

@pytorchbot merge

1 similar comment
@bdhirsh
Copy link
Collaborator Author

bdhirsh commented Nov 4, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 4, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-bionic-cuda11.7-py3.10-gcc7 / test (functorch, 1, 1, linux.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@bdhirsh
Copy link
Collaborator Author

bdhirsh commented Nov 7, 2022

@pytorchbot merge -f "flaky tests: OOM, couldnt communicate with Nvidia driver"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x ad5c124614d398191d02c92651f871132d52fc69 returned non-zero exit code 1

Auto-merging test/test_functionalization.py
CONFLICT (content): Merge conflict in test/test_functionalization.py
error: could not apply ad5c124614... reland "Do not use unsafe restriding for subclasses (#87610)"
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Details for Dev Infra team Raised by workflow job

@bdhirsh
Copy link
Collaborator Author

bdhirsh commented Nov 11, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 85d565f32dc854a8ae1b29e98ecf8f1487005374 returned non-zero exit code 1

Auto-merging test/functorch/test_aotdispatch.py
CONFLICT (content): Merge conflict in test/functorch/test_aotdispatch.py
error: could not apply 85d565f32d... reland "Do not use unsafe restriding for subclasses (#87610)"
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Details for Dev Infra team Raised by workflow job

@bdhirsh
Copy link
Collaborator Author

bdhirsh commented Nov 14, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@facebook-github-bot facebook-github-bot deleted the gh/bdhirsh/341/head branch June 8, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: composability release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants