Do not use unsafe restriding for subclasses#87610
Closed
ezyang wants to merge 10 commits intogh/ezyang/1469/basefrom
Closed
Do not use unsafe restriding for subclasses#87610ezyang wants to merge 10 commits intogh/ezyang/1469/basefrom
ezyang wants to merge 10 commits intogh/ezyang/1469/basefrom
Conversation
This helps convert some accuracy errors into runtime errors, which makes it easier to debug. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87610
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 82302cb: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
@bdhirsh is grabbing this. |
This helps convert some accuracy errors into runtime errors, which makes it easier to debug. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
This helps convert some accuracy errors into runtime errors, which makes it easier to debug. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
This was referenced Oct 26, 2022
This helps convert some accuracy errors into runtime errors, which makes it easier to debug. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
This helps convert some accuracy errors into runtime errors, which makes it easier to debug. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
This helps convert some accuracy errors into runtime errors, which makes it easier to debug. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
This helps convert some accuracy errors into runtime errors, which makes it easier to debug. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
This helps convert some accuracy errors into runtime errors, which makes it easier to debug. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Nov 2, 2022
This reverts commit 5b75b19. [ghstack-poisoned]
Collaborator
|
@pytorchbot rebase |
Collaborator
|
@pytorchbot successfully started a rebase job. Check the current status here |
Collaborator
|
Rebase failed due to |
Collaborator
|
had trouble re-using the same PR to re-land, closing in favor of #88458 |
bdhirsh
added a commit
that referenced
this pull request
Nov 3, 2022
bdhirsh
added a commit
that referenced
this pull request
Nov 3, 2022
…"" This reverts commit 5b75b19. [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Nov 4, 2022
…"" This reverts commit 5b75b19. [ghstack-poisoned]
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
This helps convert some accuracy errors into runtime errors, which makes it easier to debug. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: pytorch#87610 Approved by: https://github.com/albanD
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
This reverts commit 73379ac. Reverted pytorch#87610 on behalf of https://github.com/mehtanirav due to [Internal breakages](https://www.internalfb.com/intern/sandcastle/job/36028797828925790/insights)
bdhirsh
added a commit
that referenced
this pull request
Nov 7, 2022
…"" This reverts commit 5b75b19. [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Nov 10, 2022
…"" This reverts commit 5b75b19. [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Nov 10, 2022
…"" This reverts commit 5b75b19. [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Nov 11, 2022
…"" This reverts commit 5b75b19. [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 14, 2022
This reverts commit 5b75b19. Pull Request resolved: #88343 Approved by: https://github.com/ezyang
ezyang
added a commit
that referenced
this pull request
Nov 22, 2022
ezyang
added a commit
that referenced
this pull request
Nov 22, 2022
…"" This reverts commit 410ce96. [ghstack-poisoned]
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
This helps convert some accuracy errors into runtime errors, which makes it easier to debug. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: pytorch#87610 Approved by: https://github.com/albanD
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
This reverts commit 73379ac. Reverted pytorch#87610 on behalf of https://github.com/mehtanirav due to [Internal breakages](https://www.internalfb.com/intern/sandcastle/job/36028797828925790/insights)
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…ytorch#88343) This reverts commit 5b75b19. Pull Request resolved: pytorch#88343 Approved by: https://github.com/ezyang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This helps convert some accuracy errors into runtime errors,
which makes it easier to debug.
Signed-off-by: Edward Z. Yang ezyang@fb.com