Skip to content

reland "Do not use unsafe restriding for subclasses (#87610)"#88458

Closed
bdhirsh wants to merge 3 commits intogh/bdhirsh/342/basefrom
gh/bdhirsh/342/head
Closed

reland "Do not use unsafe restriding for subclasses (#87610)"#88458
bdhirsh wants to merge 3 commits intogh/bdhirsh/342/basefrom
gh/bdhirsh/342/head

Conversation

@bdhirsh
Copy link
Collaborator

@bdhirsh bdhirsh commented Nov 3, 2022

Stack from ghstack (oldest at bottom):

This reverts commit 410ce96.

Differential Revision: D41455350

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 3, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88458

Note: Links to docs will display an error until the docs builds have been completed.

❌ 16 Failures

As of commit cee26af:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@bdhirsh
Copy link
Collaborator Author

bdhirsh commented Nov 3, 2022

whoops, wrong commit. fixing

…ew registrations. (#88329)""

This reverts commit 410ce96.

[ghstack-poisoned]
bdhirsh added a commit that referenced this pull request Nov 3, 2022
This reverts commit 5b75b19.

ghstack-source-id: 4c662f3
Pull Request resolved: #88458
@bdhirsh bdhirsh changed the title reland "Put Python Dispatcher cache in dict, clear it on new registrations. (#88329)" reland "Do not use unsafe restriding for subclasses (#87610)" Nov 3, 2022
Copy link
Collaborator

@Chillee Chillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@bdhirsh bdhirsh added the release notes: composability release notes category label Nov 7, 2022
ezyang added a commit that referenced this pull request Nov 22, 2022
This reverts commit 5b75b19.

ghstack-source-id: 6faa89a
Pull Request resolved: #88458
@ezyang
Copy link
Contributor

ezyang commented Nov 22, 2022

@ezyang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 22, 2022
@ezyang ezyang added ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor labels Nov 22, 2022
@ezyang ezyang closed this Nov 22, 2022
@facebook-github-bot facebook-github-bot deleted the gh/bdhirsh/342/head branch June 8, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request release notes: composability release notes category topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants