Skip to content

misc symintifying fixes#88197

Closed
bdhirsh wants to merge 14 commits intogh/bdhirsh/337/basefrom
gh/bdhirsh/337/head
Closed

misc symintifying fixes#88197
bdhirsh wants to merge 14 commits intogh/bdhirsh/337/basefrom
gh/bdhirsh/337/head

Conversation

@bdhirsh
Copy link
Collaborator

@bdhirsh bdhirsh commented Nov 1, 2022 •
edited
Loading

@bdhirsh
misc symintifying fixes
4379d3a 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 1, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88197

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ae76f18:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Nov 1, 2022
Closed
Closed
Closed
Closed
@bdhirsh bdhirsh mentioned this pull request Nov 1, 2022
Closed
albanD
albanD approved these changes Nov 1, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

torch/_meta_registrations.py Outdated

@register_meta(aten.bernoulli.p)
def meta_bernoulli_p(self, p, generator=None):
return torch.empty_like(self)
Copy link
Collaborator

@albanD albanD Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is one empty_like and the other new_empty? haha

Copy link
Collaborator Author

@bdhirsh bdhirsh Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess in this case it doesn't matter :p ill make it consistent

@bdhirsh bdhirsh added release notes: composability release notes category topic: not user facing topic category labels Nov 2, 2022
@bdhirsh bdhirsh mentioned this pull request Nov 2, 2022
Closed
@bdhirsh bdhirsh mentioned this pull request Nov 2, 2022
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2023

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Jan 15, 2023
@github-actions github-actions bot closed this Feb 14, 2023
@facebook-github-bot facebook-github-bot deleted the gh/bdhirsh/337/head branch June 8, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@soulitzer soulitzer Awaiting requested review from soulitzer

@anjali411 anjali411 Awaiting requested review from anjali411

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@Chillee Chillee Awaiting requested review from Chillee

@ezyang ezyang Awaiting requested review from ezyang

@Krovatkin Krovatkin Awaiting requested review from Krovatkin

@miladm miladm Awaiting requested review from miladm

@wconstab wconstab Awaiting requested review from wconstab

Assignees

No one assigned

Labels

release notes: composability release notes category Stale topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bdhirsh @albanD