Skip to content

Symintified mmm/addmm derivative formulas#85794

Closed
Chillee wants to merge 2 commits intogh/chillee/136/basefrom
gh/chillee/136/head
Closed

Symintified mmm/addmm derivative formulas#85794
Chillee wants to merge 2 commits intogh/chillee/136/basefrom
gh/chillee/136/head

Conversation

@Chillee
Copy link
Copy Markdown
Collaborator

@Chillee Chillee commented Sep 28, 2022 •
edited
Loading

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Sep 28, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85794

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 Failures, 2 Pending

As of commit 96cd5d2:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Sep 28, 2022
Closed
Closed
Closed
Chillee added a commit that referenced this pull request Sep 28, 2022
@Chillee
Symintified mmm/addmm derivative formulas
7dadc1f 
ghstack-source-id: 646939c
Pull Request resolved: #85794
@ezyang
Copy link
Copy Markdown
Contributor

ezyang commented Sep 28, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 28, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 28, 2022

Hey @Chillee.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@janeyx99
Copy link
Copy Markdown
Contributor

janeyx99 commented Sep 28, 2022

@pytorchbot revert -m "Sorry, reverting as this breaks an aot_autograd mac test on functorch https://hud.pytorch.org/pytorch/pytorch/commit/230edd2515367fcb44cea7c40106ff9f6a712a2a" -c nosignal

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 28, 2022

@pytorchbot successfully started a revert job. Check the current status here.
Please reach out to the PyTorch DevX Team with feedback or questions!

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 28, 2022

@Chillee your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Sep 28, 2022
@pytorchmergebot
Revert "Symintified mmm/addmm derivative formulas (#85794)"
823dc33 
This reverts commit 230edd2.

Reverted #85794 on behalf of https://github.com/janeyx99 due to Sorry, reverting as this breaks an aot_autograd mac test on functorch https://hud.pytorch.org/pytorch/pytorch/commit/230edd2515367fcb44cea7c40106ff9f6a712a2a
Chillee added a commit that referenced this pull request Sep 28, 2022
@Chillee
Revert "Revert "Symintified mmm/addmm derivative formulas (#85794)""
a2fe009 
This reverts commit 823dc33.

[ghstack-poisoned]
@huydhn huydhn reopened this Sep 28, 2022
@github-actions github-actions bot requested a review from ezyang September 28, 2022 17:16
@huydhn huydhn added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 28, 2022
pytorchmergebot referenced this pull request Sep 28, 2022
@Chillee @pytorchmergebot
Registered _like metas (#85793)
a4e75cc 
Pull Request resolved: #85793
Approved by: https://github.com/ezyang
pytorchmergebot added a commit that referenced this pull request Sep 28, 2022
@pytorchmergebot
Revert "Registered _like metas (#85793)"
b44a4a8 
This reverts commit a4e75cc.

Reverted #85793 on behalf of https://github.com/huydhn due to Sorry, reverting as this breaks an aot_autograd mac test on functorch. #85794 was reverted before but it was at the top of the stack so the revert still fail https://hud.pytorch.org/pytorch/pytorch/commit/823dc33b00b811c28a3924a6f0a31ba6afee7272
Chillee added a commit that referenced this pull request Sep 28, 2022
@Chillee
Update on "Revert "Revert "Symintified mmm/addmm derivative formulas (#…
e5b5c08 
…85794)"""

This reverts commit 823dc33.

[ghstack-poisoned]
Chillee added a commit that referenced this pull request Sep 28, 2022
@Chillee
Revert "Revert "Symintified mmm/addmm derivative formulas (#85794)""
66080c9 
This reverts commit 823dc33.

ghstack-source-id: bdd403e
Pull Request resolved: #85820
@huydhn huydhn closed this Sep 28, 2022
pytorchmergebot pushed a commit that referenced this pull request Sep 28, 2022
@Chillee @pytorchmergebot
Revert "Revert "Symintified mmm/addmm derivative formulas (#85794)"" (#…
a4bd89b 
…85820)

This reverts commit 823dc33.
Pull Request resolved: #85820
Approved by: https://github.com/huydhn
drisspg pushed a commit to drisspg/pytorch that referenced this pull request Sep 29, 2022
@Chillee @drisspg
Symintified mmm/addmm derivative formulas (pytorch#85794)
adf5e5b 
Pull Request resolved: pytorch#85794
Approved by: https://github.com/ezyang
drisspg pushed a commit to drisspg/pytorch that referenced this pull request Sep 29, 2022
@pytorchmergebot @drisspg
Revert "Symintified mmm/addmm derivative formulas (pytorch#85794)"
2780ffa 
This reverts commit 230edd2.

Reverted pytorch#85794 on behalf of https://github.com/janeyx99 due to Sorry, reverting as this breaks an aot_autograd mac test on functorch https://hud.pytorch.org/pytorch/pytorch/commit/230edd2515367fcb44cea7c40106ff9f6a712a2a
@huydhn huydhn mentioned this pull request Sep 29, 2022
Closed
@facebook-github-bot facebook-github-bot deleted the gh/chillee/136/head branch October 2, 2022 14:19
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@Chillee @mehtanirav
Symintified mmm/addmm derivative formulas (#85794)
3cd94d8 
Pull Request resolved: #85794
Approved by: https://github.com/ezyang
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@pytorchmergebot @mehtanirav
Revert "Symintified mmm/addmm derivative formulas (#85794)"
53a9e94 
This reverts commit 230edd2.

Reverted #85794 on behalf of https://github.com/janeyx99 due to Sorry, reverting as this breaks an aot_autograd mac test on functorch https://hud.pytorch.org/pytorch/pytorch/commit/230edd2515367fcb44cea7c40106ff9f6a712a2a
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@pytorchmergebot @mehtanirav
Revert "Registered _like metas (#85793)"
e65b40f 
This reverts commit a4e75cc.

Reverted #85793 on behalf of https://github.com/huydhn due to Sorry, reverting as this breaks an aot_autograd mac test on functorch. #85794 was reverted before but it was at the top of the stack so the revert still fail https://hud.pytorch.org/pytorch/pytorch/commit/823dc33b00b811c28a3924a6f0a31ba6afee7272
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@Chillee @mehtanirav
Revert "Revert "Symintified mmm/addmm derivative formulas (#85794)"" (#…
3bcf74e 
…85820)

This reverts commit 823dc33.
Pull Request resolved: #85820
Approved by: https://github.com/huydhn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD Awaiting requested review from albanD

@soulitzer soulitzer Awaiting requested review from soulitzer

@anjali411 anjali411 Awaiting requested review from anjali411

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@Krovatkin Krovatkin Awaiting requested review from Krovatkin

@wconstab wconstab Awaiting requested review from wconstab

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Chillee @ezyang @pytorchmergebot @janeyx99 @huydhn @facebook-github-bot