Added floordiv simplification rule needed for models#85768
Closed
Chillee wants to merge 1 commit intogh/chillee/130/basefrom
Closed
Added floordiv simplification rule needed for models#85768Chillee wants to merge 1 commit intogh/chillee/130/basefrom
Chillee wants to merge 1 commit intogh/chillee/130/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85768
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit aa3d9b4: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
approved these changes
Sep 27, 2022
Contributor
|
For reference, how did you figure it out? |
Collaborator
Author
|
@ezyang I saw all the time was being spent in I took a closer look at one of them, and realized that the numerator was something like |
Contributor
|
Seems like we should record stats on expression complexity so we can see if this sort of thing is happening |
This was referenced Sep 28, 2022
drisspg
pushed a commit
to drisspg/pytorch
that referenced
this pull request
Sep 29, 2022
Pull Request resolved: pytorch#85768 Approved by: https://github.com/ezyang
mehtanirav
pushed a commit
that referenced
this pull request
Oct 4, 2022
Pull Request resolved: #85768 Approved by: https://github.com/ezyang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):