Skip to content

Revert "Revert "Symintified mmm/addmm derivative formulas (#85794)""#85820

Closed
Chillee wants to merge 2 commits intogh/chillee/137/basefrom
gh/chillee/137/head
Closed

Revert "Revert "Symintified mmm/addmm derivative formulas (#85794)""#85820
Chillee wants to merge 2 commits intogh/chillee/137/basefrom
gh/chillee/137/head

Conversation

@Chillee
Copy link
Copy Markdown
Collaborator

@Chillee Chillee commented Sep 28, 2022 •
edited
Loading

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Sep 28, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85820

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit e5b5c08:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn huydhn mentioned this pull request Sep 28, 2022
Closed
@huydhn huydhn added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 28, 2022
Chillee added a commit that referenced this pull request Sep 28, 2022
@Chillee
Revert "Revert "Symintified mmm/addmm derivative formulas (#85794)""
66080c9 
This reverts commit 823dc33.

ghstack-source-id: bdd403e
Pull Request resolved: #85820
@Chillee
Copy link
Copy Markdown
Collaborator Author

Chillee commented Sep 28, 2022

@pytorchbot merge -f "forward fix for macos breakage introduced in #85789"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 28, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 28, 2022

Hey @Chillee.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@huydhn huydhn mentioned this pull request Sep 29, 2022
Closed
@facebook-github-bot facebook-github-bot deleted the gh/chillee/137/head branch October 2, 2022 14:19
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@Chillee @mehtanirav
Revert "Revert "Symintified mmm/addmm derivative formulas (#85794)"" (#…
3bcf74e 
…85820)

This reverts commit 823dc33.
Pull Request resolved: #85820
Approved by: https://github.com/huydhn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@albanD albanD Awaiting requested review from albanD

@soulitzer soulitzer Awaiting requested review from soulitzer

@anjali411 anjali411 Awaiting requested review from anjali411

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@ezyang ezyang Awaiting requested review from ezyang

@Krovatkin Krovatkin Awaiting requested review from Krovatkin

@miladm miladm Awaiting requested review from miladm

@wconstab wconstab Awaiting requested review from wconstab

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Chillee @pytorchmergebot @huydhn @facebook-github-bot