Skip to content

Remove flacky test and replace with Mocking test#80159

Closed
davidchencsl wants to merge 4 commits intogh/davidchencsl/12/basefrom
gh/davidchencsl/12/head
Closed

Remove flacky test and replace with Mocking test#80159
davidchencsl wants to merge 4 commits intogh/davidchencsl/12/basefrom
gh/davidchencsl/12/head

Conversation

@davidchencsl
Copy link
Copy Markdown
Contributor

@davidchencsl davidchencsl commented Jun 23, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

This PR removes the flaky test that was introduce in the previous commit, and replace it with a mocking test. The actual test of queue depth is added in the next commit.

This was referenced Jun 23, 2022
Closed
Closed
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 23, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 8ff84fb (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Jun 23, 2022
Closed
Closed
@davidchencsl davidchencsl linked an issue Jun 23, 2022 that may be closed by this pull request
DISABLED test_utils_compute_queue_depth (__main__.TestProfiler) #80125
Closed
@davidchencsl davidchencsl requested a review from robieta June 23, 2022 22:31
robieta
robieta reviewed Jun 24, 2022
View reviewed changes
Comment thread test/test_profiler.py Outdated
Comment thread test/test_profiler.py
@davidchencsl
Update on "Remove flacky test and replace with Mocking test"
8ff84fb 
This PR removes the flaky test that was introduce in the previous commit, and replace it with a mocking test. The actual test of queue depth is added in the next commit.

[ghstack-poisoned]
robieta
robieta approved these changes Jun 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@robieta robieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@robieta robieta added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 24, 2022
@davidchencsl
Copy link
Copy Markdown
Contributor Author

davidchencsl commented Jun 24, 2022

@pytorchmergebot please merge

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Jun 24, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'please' (choose from 'merge', 'revert', 'rebase')

usage: @pytorchbot [-h] {merge,revert,rebase} ...

Try @pytorchbot --help for more info.

@davidchencsl
Copy link
Copy Markdown
Contributor Author

davidchencsl commented Jun 24, 2022

@pytorchmergebot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 24, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 24, 2022

Hey @davidchencsl.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 27, 2022
@davidchencsl @facebook-github-bot
Remove flacky test and replace with Mocking test (#80159) (#80159)
7a165e5 
Summary:
This PR removes the flaky test that was introduce in the previous commit, and replace it with a mocking test. The actual test of queue depth is added in the next commit.

Pull Request resolved: #80159
Approved by: https://github.com/robieta

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/8cfb8f94a08628b5941a0912b3945c3976e69c46

Reviewed By: atalman

Differential Revision: D37455665

Pulled By: davidchencsl

fbshipit-source-id: 387be77bed7d9d3e9631d34dacf97de586e08a94
@facebook-github-bot facebook-github-bot deleted the gh/davidchencsl/12/head branch June 28, 2022 14:17
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@davidchencsl @pytorchmergebot
Remove flacky test and replace with Mocking test (pytorch#80159)
71632f7 
This PR removes the flaky test that was introduce in the previous commit, and replace it with a mocking test. The actual test of queue depth is added in the next commit.
Pull Request resolved: pytorch#80159
Approved by: https://github.com/robieta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robieta robieta robieta approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DISABLED test_utils_compute_queue_depth (__main__.TestProfiler)

4 participants

@davidchencsl @facebook-github-bot @pytorchmergebot @robieta