[Profiler] Add heuristic to rank events base on computed metrics#80094
Closed
davidchencsl wants to merge 12 commits intogh/davidchencsl/8/basefrom
Closed
[Profiler] Add heuristic to rank events base on computed metrics#80094davidchencsl wants to merge 12 commits intogh/davidchencsl/8/basefrom
davidchencsl wants to merge 12 commits intogh/davidchencsl/8/basefrom
Conversation
[ghstack-poisoned]
This was referenced Jun 22, 2022
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 0caab93 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…etrics" Test Plan: Add test in test_profiler.py [ghstack-poisoned]
…etrics" Test Plan: Add test in test_profiler.py [ghstack-poisoned]
…etrics" Test Plan: Add test in test_profiler.py [ghstack-poisoned]
…etrics" Test Plan: Add test in test_profiler.py [ghstack-poisoned]
…etrics" Test Plan: Add test in test_profiler.py [ghstack-poisoned]
…etrics" Test Plan: Add test in test_profiler.py [ghstack-poisoned]
robieta
reviewed
Jun 24, 2022
Contributor
robieta
left a comment
There was a problem hiding this comment.
Still digesting the main algorithm, but had a couple thoughts on the unit tests.
…etrics" Test Plan: Add test in test_profiler.py [ghstack-poisoned]
robieta
requested changes
Jun 28, 2022
…etrics" Test Plan: Add test in test_profiler.py to check idle time computation. To test the heuristic, we use serialized real world data stored in test_profiler_utils_golden.py to ensure a run to run stable test. [ghstack-poisoned]
…etrics" Test Plan: Add test in test_profiler.py to check idle time computation. To test the heuristic, we use serialized real world data stored in test_profiler_utils_golden.py to ensure a run to run stable test. [ghstack-poisoned]
…etrics" Test Plan: Add test in test_profiler.py to check idle time computation. To test the heuristic, we use serialized real world data stored in test_profiler_utils_golden.py to ensure a run to run stable test. [ghstack-poisoned]
robieta
approved these changes
Jul 1, 2022
Contributor
robieta
left a comment
There was a problem hiding this comment.
LGTM. (modulo nits) The windows failures don't look related, but probably makes sense to rebase until CI is green.
…etrics" Test Plan: Add test in test_profiler.py to check idle time computation. To test the heuristic, we use serialized real world data stored in test_profiler_utils_golden.py to ensure a run to run stable test. [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Contributor
|
Hey @davidchencsl. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
) (#80094) Summary: Pull Request resolved: #80094 Approved by: https://github.com/robieta Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/007100892718cc926b4e88e6d8a8ff5616b44428 Test plan from GitHub: Add test in test_profiler.py to check idle time computation. To test the heuristic, we use serialized real world data stored in test_profiler_utils_golden.py to ensure a run to run stable test. Reviewed By: mehtanirav Differential Revision: D37648867 Pulled By: davidchencsl fbshipit-source-id: af8af8892a42cd3912486a63ad5deb0e668024dd
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
…orch#80094) Test Plan: Add test in test_profiler.py to check idle time computation. To test the heuristic, we use serialized real world data stored in test_profiler_utils_golden.py to ensure a run to run stable test. Pull Request resolved: pytorch#80094 Approved by: https://github.com/robieta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Test Plan:
Add test in test_profiler.py to check idle time computation.
To test the heuristic, we use serialized real world data stored in test_profiler_utils_golden.py to ensure a run to run stable test.