Skip to content

Strengthening unit test cases for queue depth calculation#79974

Closed
davidchencsl wants to merge 4 commits intogh/davidchencsl/5/basefrom
gh/davidchencsl/5/head
Closed

Strengthening unit test cases for queue depth calculation#79974
davidchencsl wants to merge 4 commits intogh/davidchencsl/5/basefrom
gh/davidchencsl/5/head

Conversation

@davidchencsl
Copy link
Copy Markdown
Contributor

@davidchencsl davidchencsl commented Jun 21, 2022 •
edited
Loading

@davidchencsl davidchencsl mentioned this pull request Jun 21, 2022
Closed
davidchencsl added a commit that referenced this pull request Jun 21, 2022
@davidchencsl
Strengthening unit test cases for quueue depth calculation
40933b5 
ghstack-source-id: 30b70aa
Pull Request resolved: #79974
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 21, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit bfd8487 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@davidchencsl davidchencsl requested a review from robieta June 21, 2022 20:44
@davidchencsl davidchencsl changed the title Strengthening unit test cases for quueue depth calculation Strengthening unit test cases for queue depth calculation Jun 21, 2022
@davidchencsl davidchencsl mentioned this pull request Jun 21, 2022
Closed
robieta
robieta approved these changes Jun 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@robieta robieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll ping DevInfra about why you're getting a lint error on an unchanged file.

@davidchencsl davidchencsl mentioned this pull request Jun 22, 2022
Closed
This was referenced Jun 22, 2022
Closed
Closed
@davidchencsl
Copy link
Copy Markdown
Contributor Author

davidchencsl commented Jun 23, 2022

@pytorchmergebot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 23, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 23, 2022

Hey @davidchencsl.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 23, 2022
@davidchencsl @facebook-github-bot
Strengthening unit test cases for quueue depth calculation (#79974)
e6f6504 
Summary:
Pull Request resolved: #79974

Approved by: https://github.com/robieta

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/38ee99b3824d2bb7e1d7cfda8077cf3af160bc4f

Reviewed By: atalman

Differential Revision: D37382027

Pulled By: davidchencsl

fbshipit-source-id: bf4741a0179cc8ea7db927c825e8d3725801ed10
@davidchencsl davidchencsl mentioned this pull request Jun 23, 2022
Closed
@facebook-github-bot facebook-github-bot deleted the gh/davidchencsl/5/head branch June 26, 2022 14:16
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@davidchencsl @pytorchmergebot
Strengthening unit test cases for quueue depth calculation
125613a 
Pull Request resolved: pytorch#79974

Approved by: https://github.com/robieta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robieta robieta robieta approved these changes

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davidchencsl @facebook-github-bot @pytorchmergebot @robieta