Skip to content

Deprecate torch.lu#77636

Closed
lezcano wants to merge 10 commits intogh/Lezcano/74/basefrom
gh/Lezcano/74/head
Closed

Deprecate torch.lu#77636
lezcano wants to merge 10 commits intogh/Lezcano/74/basefrom
gh/Lezcano/74/head

Conversation

@lezcano
Copy link
Copy Markdown
Collaborator

@lezcano lezcano commented May 17, 2022

Stack from ghstack:

This PR deprecates torch.lu in favor of torch.linalg.lu_factor.
A upgrade guide is added to the documentation for torch.lu.

Note this PR DOES NOT remove torch.lu.

Reland #73804

BC-breaking note

Deprecate torch.lu in favor of linalg.lu_factor

The new operation has a cleaner API and better docs. The update rule is as follows:

Version 1.12.0

LU1, pivots1, info = torch.lu(A, compute_pivots)
LU2, pivots2, info = torch.lu(A, compute_pivots, get_infos=True)

Version 1.13.0

LU1, pivots1 = torch.linalg.lu_factor(A, compute_pivots)
LU2, pivots2, info = torch.linalg.lu_factor_ex(A, compute_pivots)

**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 17, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit c1cf627 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@lezcano lezcano added module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul release notes: linalg_frontend release notes category topic: deprecation topic category labels May 17, 2022
@lezcano lezcano requested review from malfet and removed request for IvanYashchuk, mruberry, ngimel and nikitaved May 17, 2022 09:08
@lezcano lezcano mentioned this pull request May 17, 2022
lezcano added 7 commits May 17, 2022 10:31
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Reland #73804

[ghstack-poisoned]
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Reland #73804

[ghstack-poisoned]
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Reland #73804

[ghstack-poisoned]
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Reland #73804

[ghstack-poisoned]
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Reland #73804

[ghstack-poisoned]
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Reland #73804

[ghstack-poisoned]
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Reland #73804

[ghstack-poisoned]
lezcano added 2 commits May 25, 2022 17:27
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Reland #73804

[ghstack-poisoned]
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Reland #73804

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Jun 8, 2022
Summary:
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Pull Request resolved: #77636

Approved by: https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f7b9a4688091d1118a4052dea6a73875fb956f79

Reviewed By: osalpekar

Differential Revision: D36993319

Pulled By: osalpekar

fbshipit-source-id: 13bbcee3c95820007691ab0fb357a9475c6d9a1e
@facebook-github-bot facebook-github-bot deleted the gh/Lezcano/74/head branch June 11, 2022 14:17
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
**BC-breaking note**:

This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`.
A upgrade guide is added to the documentation for `torch.lu`.

Note this PR DOES NOT remove `torch.lu`.

Pull Request resolved: pytorch#77636

Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul open source release notes: linalg_frontend release notes category topic: deprecation topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants