Deprecate torch.lu by lezcano · Pull Request #73804 · pytorch/pytorch

lezcano · 2022-03-04T19:17:31Z

Stack from ghstack:

BC-breaking note:

This PR deprecates torch.lu in favor of torch.linalg.lu_factor.
A upgrade guide is added to the documentation for torch.lu.

Note this PR DOES NOT remove torch.lu.

**BC-breaking note**: This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`. A upgrade guide is added to the documentation for `torch.lu`. Note this PR DOES NOT remove `torch.lu`. [ghstack-poisoned]

pytorch-bot · 2022-03-04T19:17:35Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/41f680e44856895c3fefee390efc04ac53a7d856/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
linux-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
linux-binary-manywheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`	✅ triggered
linux-bionic-rocm4.5-py3.7	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/rocm`, `ciflow/trunk`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4-mobile-lightweight-dispatch-build	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
macos-arm64-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
macos-arm64-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
macos-binary-conda	`ciflow/binaries`, `ciflow/binaries_conda`, `ciflow/default`	✅ triggered
macos-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
macos-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
macos-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
windows-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
windows-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries_libtorch`, `ciflow/default`	✅ triggered
windows-binary-wheel	`ciflow/binaries`, `ciflow/binaries_wheel`, `ciflow/default`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/scheduled`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	🚫 skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.3-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
pytorch-xla-linux-bionic-py3.7-clang8	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`, `ciflow/xla`	🚫 skipped

facebook-github-bot · 2022-03-04T19:17:45Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/73804
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

❌ 3 New Failures

As of commit f9153ad (more details on the Dr. CI page):

Expand to see more

3/3 failures introduced in this PR

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages

pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (1/3)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-05-11T11:47:40.9828394Z torch/csrc/utils/p...:64: error: 'func_' was not declared in this scope

2022-05-11T11:47:40.9820137Z Use --sandbox_debug to see verbose messages from the sandbox
2022-05-11T11:47:40.9820945Z torch/csrc/utils/python_dispatch.cpp:58:3: error: 'SafePyObject' does not name a type; did you mean 'createPyObject'?
2022-05-11T11:47:40.9821552Z    SafePyObject func_;
2022-05-11T11:47:40.9821851Z    ^~~~~~~~~~~~
2022-05-11T11:47:40.9822302Z    createPyObject
2022-05-11T11:47:40.9823313Z torch/csrc/utils/python_dispatch.cpp: In constructor 'torch::impl::dispatch::PythonKernelHolder::PythonKernelHolder(pybind11::object)':
2022-05-11T11:47:40.9824573Z torch/csrc/utils/python_dispatch.cpp:60:41: error: class 'torch::impl::dispatch::PythonKernelHolder' does not have any field named 'func_'
2022-05-11T11:47:40.9825397Z    PythonKernelHolder(py::object func) : func_(func.release().ptr(), getPyInterpreter()) {}
2022-05-11T11:47:40.9826226Z                                          ^~~~~
2022-05-11T11:47:40.9827235Z torch/csrc/utils/python_dispatch.cpp: In member function 'void torch::impl::dispatch::PythonKernelHolder::operator()(const c10::OperatorHandle&, c10::DispatchKeySet, torch::jit::Stack*)':
2022-05-11T11:47:40.9828394Z torch/csrc/utils/python_dispatch.cpp:66:64: error: 'func_' was not declared in this scope
2022-05-11T11:47:40.9829168Z      auto obj = py::reinterpret_steal<py::object>(PyObject_Call(func_.ptr(getPyInterpreter()), args_kwargs.first.ptr(), args_kwargs.second.ptr()));
2022-05-11T11:47:40.9829840Z                                                                 ^~~~~
2022-05-11T11:47:42.1850609Z �[32mINFO: �[0mElapsed time: 1742.059s, Critical Path: 383.80s
2022-05-11T11:47:42.1851033Z �[32mINFO: �[0m3430 processes: 351 internal, 3079 processwrapper-sandbox.
2022-05-11T11:47:42.1851375Z �[31m�[1mFAILED:�[0m Build did NOT complete successfully
2022-05-11T11:47:42.1864399Z �[31m�[1mFAILED:�[0m Build did NOT complete successfully
2022-05-11T11:47:42.1953038Z �[0m+ cleanup
2022-05-11T11:47:42.1953236Z + retcode=1
2022-05-11T11:47:42.1953391Z + set +x
2022-05-11T11:47:42.1993015Z ##[error]Process completed with exit code 1.

pull / linux-xenial-py3.7-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (2/3)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-11T11:18:59.7320581Z The PR is introduc...m to confirm whether this change is wanted or not.

2022-05-11T11:18:59.7306030Z processing existing schema:  text(__torch__.torch.classes.profiling.SourceRef _0) -> (str _0)
2022-05-11T11:18:59.7307532Z processing existing schema:  count(__torch__.torch.classes.profiling.InstructionStats _0) -> (int _0)
2022-05-11T11:18:59.7309025Z processing existing schema:  duration_ns(__torch__.torch.classes.profiling.InstructionStats _0) -> (int _0)
2022-05-11T11:18:59.7310626Z processing existing schema:  source(__torch__.torch.classes.profiling.SourceStats _0) -> (__torch__.torch.classes.profiling.SourceRef _0)
2022-05-11T11:18:59.7312479Z processing existing schema:  line_map(__torch__.torch.classes.profiling.SourceStats _0) -> (Dict(int, __torch__.torch.classes.profiling.InstructionStats) _0)
2022-05-11T11:18:59.7314020Z processing existing schema:  __init__(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-05-11T11:18:59.7315119Z processing existing schema:  enable(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-05-11T11:18:59.7316564Z processing existing schema:  disable(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-05-11T11:18:59.7318434Z processing existing schema:  _dump_stats(__torch__.torch.classes.profiling._ScriptProfile _0) -> (__torch__.torch.classes.profiling.SourceStats[] _0)
2022-05-11T11:18:59.7320115Z processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> (NoneType _0)
2022-05-11T11:18:59.7320581Z The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
2022-05-11T11:18:59.7320592Z 
2022-05-11T11:18:59.7320728Z Broken ops: [
2022-05-11T11:18:59.7321175Z 	aten::set_.source_Tensor_storage_offset(Tensor(a!) self, Tensor source, int storage_offset, int[] size, int[] stride=[]) -> (Tensor(a!))
2022-05-11T11:18:59.7321312Z 	prim::oneDNNFusionGroup(...) -> (...)
2022-05-11T11:18:59.7321457Z 	prim::oneDNNFusionGuard(...) -> (...)
2022-05-11T11:18:59.7321641Z 	aten::linalg_vander(Tensor x, *, int? N=None) -> (Tensor)
2022-05-11T11:18:59.7321706Z ]
2022-05-11T11:18:59.8321924Z + cleanup
2022-05-11T11:18:59.8322025Z + retcode=1
2022-05-11T11:18:59.8322096Z + set +x

pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (3/3)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-11T12:38:47.6564407Z /var/lib/jenkins/w... virtual member functions can be marked 'override'

2022-05-11T12:38:47.6558796Z In file included from /var/lib/jenkins/workspace/xla/torch_xla/csrc/aten_xla_bridge.cpp:11:
2022-05-11T12:38:47.6559622Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/tensor_impl.h:33:40: error: only virtual member functions can be marked 'override'
2022-05-11T12:38:47.6560199Z   at::IntArrayRef sizes_custom() const override;
2022-05-11T12:38:47.6560566Z                                        ^~~~~~~~
2022-05-11T12:38:47.6561261Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/tensor_impl.h:34:42: error: only virtual member functions can be marked 'override'
2022-05-11T12:38:47.6561801Z   at::IntArrayRef strides_custom() const override;
2022-05-11T12:38:47.6562162Z                                          ^~~~~~~~
2022-05-11T12:38:47.6562849Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/tensor_impl.h:36:30: error: only virtual member functions can be marked 'override'
2022-05-11T12:38:47.6563377Z   int64_t dim_custom() const override;
2022-05-11T12:38:47.6563716Z                              ^~~~~~~~
2022-05-11T12:38:47.6564407Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/tensor_impl.h:38:32: error: only virtual member functions can be marked 'override'
2022-05-11T12:38:47.6564917Z   int64_t numel_custom() const override;
2022-05-11T12:38:47.6565257Z                                ^~~~~~~~
2022-05-11T12:38:47.6565556Z 4 errors generated.
2022-05-11T12:38:48.5583238Z [9/179] clang++-8 -MMD -MF /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.7/torch_xla/csrc/computation.o.d -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -D_GLIBCXX_USE_CXX11_ABI=1 -fPIC -I/var/lib/jenkins/workspace/xla -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-bin -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/protobuf_archive/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_protobuf/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/eigen_archive -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_absl -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/torch/csrc -I/var/lib/jenkins/workspace/torch/lib/tmp_install/include -I/opt/conda/lib/python3.7/site-packages/torch/include -I/opt/conda/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.7/site-packages/torch/include/TH -I/opt/conda/lib/python3.7/site-packages/torch/include/THC -I/opt/conda/include/python3.7m -c -c /var/lib/jenkins/workspace/xla/torch_xla/csrc/computation.cpp -o /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.7/torch_xla/csrc/computation.o -std=c++14 -Wno-sign-compare -Wno-deprecated-declarations -Wno-return-type -Wno-macro-redefined -Wno-return-std-move -DNDEBUG -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_clang"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1002"' -DTORCH_EXTENSION_NAME=_XLAC -D_GLIBCXX_USE_CXX11_ABI=1
2022-05-11T12:39:13.5971322Z [10/179] clang++-8 -MMD -MF /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.7/torch_xla/csrc/RegisterXLA.o.d -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -D_GLIBCXX_USE_CXX11_ABI=1 -fPIC -I/var/lib/jenkins/workspace/xla -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-bin -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/protobuf_archive/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_protobuf/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/eigen_archive -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_absl -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/torch/csrc -I/var/lib/jenkins/workspace/torch/lib/tmp_install/include -I/opt/conda/lib/python3.7/site-packages/torch/include -I/opt/conda/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.7/site-packages/torch/include/TH -I/opt/conda/lib/python3.7/site-packages/torch/include/THC -I/opt/conda/include/python3.7m -c -c /var/lib/jenkins/workspace/xla/torch_xla/csrc/RegisterXLA.cpp -o /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.7/torch_xla/csrc/RegisterXLA.o -std=c++14 -Wno-sign-compare -Wno-deprecated-declarations -Wno-return-type -Wno-macro-redefined -Wno-return-std-move -DNDEBUG -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_clang"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1002"' -DTORCH_EXTENSION_NAME=_XLAC -D_GLIBCXX_USE_CXX11_ABI=1
2022-05-11T12:39:13.5973929Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/RegisterXLA.cpp:63:6: warning: unused function 'resize_out' [-Wunused-function]
2022-05-11T12:39:13.5974358Z void resize_out(const Tensor &out, IntArrayRef sizes, IntArrayRef strides, const TensorOptions &options) {
2022-05-11T12:39:13.5974613Z      ^
2022-05-11T12:39:13.5975007Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/RegisterXLA.cpp:82:6: warning: unused function 'check_inplace' [-Wunused-function]
2022-05-11T12:39:13.5975393Z void check_inplace(const Tensor &self, IntArrayRef sizes, const TensorOptions &options) {

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

**BC-breaking note**: This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`. A upgrade guide is added to the documentation for `torch.lu`. Note this PR DOES NOT remove `torch.lu`. [ghstack-poisoned]

IvanYashchuk · 2022-03-10T10:41:25Z

There are a few problems with the suggested code in the warning message.

**BC-breaking note**: This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`. A upgrade guide is added to the documentation for `torch.lu`. Note this PR DOES NOT remove `torch.lu`. [ghstack-poisoned]

malfet · 2022-05-09T19:05:18Z

@pytorchbot revert this, as dependent change of #72935 that breaks internal build

This reverts commit a5bbfd9. Reverted #73804 on behalf of https://github.com/malfet

lezcano · 2022-05-17T09:09:36Z

Relanding in #77636

**BC-breaking note**: This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`. A upgrade guide is added to the documentation for `torch.lu`. Note this PR DOES NOT remove `torch.lu`. Reland #73804 [ghstack-poisoned]

**BC-breaking note**: This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`. A upgrade guide is added to the documentation for `torch.lu`. Note this PR DOES NOT remove `torch.lu`. Pull Request resolved: pytorch#73804 Approved by: https://github.com/IvanYashchuk, https://github.com/mruberry

This reverts commit 0f6d107. Reverted pytorch#73804 on behalf of https://github.com/malfet

Deprecate torch.lu

41f680e

**BC-breaking note**: This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`. A upgrade guide is added to the documentation for `torch.lu`. Note this PR DOES NOT remove `torch.lu`. [ghstack-poisoned]

lezcano requested review from IvanYashchuk and nikitaved as code owners March 4, 2022 19:17

lezcano mentioned this pull request Mar 4, 2022

Add linalg.lu #67833

Closed

pytorch-bot Bot added the ciflow/default label Mar 4, 2022

lezcano mentioned this pull request Mar 4, 2022

Add linalg.lu_solve #72935

Closed

lezcano mentioned this pull request Mar 4, 2022

Update torch.lu_unpack docs #73803

Closed

facebook-github-bot added the cla signed label Mar 4, 2022

pytorchbot added the open source label Mar 4, 2022

lezcano mentioned this pull request Mar 4, 2022

Deprecate torch.lu_solve #73806

Closed

lezcano requested a review from mruberry March 4, 2022 19:31

lezcano added 5 commits March 4, 2022 19:37

Update on "Deprecate torch.lu"

ad0a5a5

**BC-breaking note**: This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`. A upgrade guide is added to the documentation for `torch.lu`. Note this PR DOES NOT remove `torch.lu`. [ghstack-poisoned]

Update on "Deprecate torch.lu"

b6e14ec

**BC-breaking note**: This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`. A upgrade guide is added to the documentation for `torch.lu`. Note this PR DOES NOT remove `torch.lu`. [ghstack-poisoned]

Update on "Deprecate torch.lu"

1d4a91b

**BC-breaking note**: This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`. A upgrade guide is added to the documentation for `torch.lu`. Note this PR DOES NOT remove `torch.lu`. [ghstack-poisoned]

Update on "Deprecate torch.lu"

c68b1d3

**BC-breaking note**: This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`. A upgrade guide is added to the documentation for `torch.lu`. Note this PR DOES NOT remove `torch.lu`. [ghstack-poisoned]

Update on "Deprecate torch.lu"

41d80b1

**BC-breaking note**: This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`. A upgrade guide is added to the documentation for `torch.lu`. Note this PR DOES NOT remove `torch.lu`. [ghstack-poisoned]

This was referenced Mar 7, 2022

Expose lu_factor_batched_cublas #73877

Closed

Update and improve the heuristics for linalg.lu_factor #73878

Closed

lezcano added the module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul label Mar 8, 2022

lezcano added 2 commits March 8, 2022 18:16

Update on "Deprecate torch.lu"

c0d636e

**BC-breaking note**: This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`. A upgrade guide is added to the documentation for `torch.lu`. Note this PR DOES NOT remove `torch.lu`. [ghstack-poisoned]

Update on "Deprecate torch.lu"

cdf955b

**BC-breaking note**: This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`. A upgrade guide is added to the documentation for `torch.lu`. Note this PR DOES NOT remove `torch.lu`. [ghstack-poisoned]

IvanYashchuk reviewed Mar 10, 2022

View reviewed changes

Comment thread aten/src/ATen/native/BatchLinearAlgebra.cpp Outdated

Comment thread aten/src/ATen/native/BatchLinearAlgebra.cpp Outdated

Comment thread torch/functional.py

Comment thread torch/functional.py Outdated

Update on "Deprecate torch.lu"

f686765

**BC-breaking note**: This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`. A upgrade guide is added to the documentation for `torch.lu`. Note this PR DOES NOT remove `torch.lu`. [ghstack-poisoned]

This was referenced Mar 10, 2022

Add support for vectors on the rhs of linalg.lu_solve #74045

Closed

Simplify and optimize linalg.solve #74046

Closed

Update on "Deprecate torch.lu"

5a0d4c4

**BC-breaking note**: This PR deprecates `torch.lu` in favor of `torch.linalg.lu_factor`. A upgrade guide is added to the documentation for `torch.lu`. Note this PR DOES NOT remove `torch.lu`. [ghstack-poisoned]

pytorchmergebot added the Reverted label May 9, 2022

pytorchmergebot added a commit that referenced this pull request May 9, 2022

Revert "Deprecate torch.lu"

1467e0d

This reverts commit a5bbfd9. Reverted #73804 on behalf of https://github.com/malfet

IvanYashchuk restored the gh/Lezcano/49/head branch May 11, 2022 11:03

IvanYashchuk reopened this May 11, 2022

lezcano mentioned this pull request May 17, 2022

Deprecate torch.lu #77636

Closed

lezcano closed this May 17, 2022

janeyx99 mentioned this pull request May 18, 2022

[Meta] CI Revert Tracker #66178

Closed

facebook-github-bot deleted the gh/Lezcano/49/head branch May 20, 2022 14:17

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026

Revert "Deprecate torch.lu"

ad3c733

This reverts commit 0f6d107. Reverted pytorch#73804 on behalf of https://github.com/malfet

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate torch.lu#73804

Deprecate torch.lu#73804
lezcano wants to merge 33 commits intogh/Lezcano/49/basefrom
gh/Lezcano/49/head

lezcano commented Mar 4, 2022 •

edited

Loading

Uh oh!

pytorch-bot Bot commented Mar 4, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Mar 4, 2022 •

edited

Loading

🕵️ 3 new failures recognized by patterns

pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (1/3)

pull / linux-xenial-py3.7-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (2/3)

pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (3/3)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IvanYashchuk commented Mar 10, 2022

Uh oh!

malfet commented May 9, 2022

Uh oh!

lezcano commented May 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

lezcano commented Mar 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Mar 4, 2022

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Mar 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

❌ 3 New Failures

🕵️ 3 new failures recognized by patterns

pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (1/3)

pull / linux-xenial-py3.7-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (2/3)

pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (3/3)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IvanYashchuk commented Mar 10, 2022

Uh oh!

malfet commented May 9, 2022

Uh oh!

lezcano commented May 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

lezcano commented Mar 4, 2022 •

edited

Loading

facebook-github-bot commented Mar 4, 2022 •

edited

Loading