Deprecate torch.lu_solve#77637
Closed
lezcano wants to merge 10 commits intogh/Lezcano/75/basefrom
Closed
Conversation
**BC-breaking note**: This PR deprecates `torch.lu_solve` in favor of `torch.linalg.lu_solve_factor`. A upgrade guide is added to the documentation for `torch.lu_solve`. Note this PR DOES NOT remove `torch.lu_solve`. [ghstack-poisoned]
This was referenced May 17, 2022
Closed
Closed
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 8641d3e (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
**BC-breaking note**: This PR deprecates `torch.lu_solve` in favor of `torch.linalg.lu_solve_factor`. A upgrade guide is added to the documentation for `torch.lu_solve`. Note this PR DOES NOT remove `torch.lu_solve`. Relanding #73806 [ghstack-poisoned]
**BC-breaking note**: This PR deprecates `torch.lu_solve` in favor of `torch.linalg.lu_solve_factor`. A upgrade guide is added to the documentation for `torch.lu_solve`. Note this PR DOES NOT remove `torch.lu_solve`. Relanding #73806 [ghstack-poisoned]
**BC-breaking note**: This PR deprecates `torch.lu_solve` in favor of `torch.linalg.lu_solve_factor`. A upgrade guide is added to the documentation for `torch.lu_solve`. Note this PR DOES NOT remove `torch.lu_solve`. Relanding #73806 [ghstack-poisoned]
**BC-breaking note**: This PR deprecates `torch.lu_solve` in favor of `torch.linalg.lu_solve_factor`. A upgrade guide is added to the documentation for `torch.lu_solve`. Note this PR DOES NOT remove `torch.lu_solve`. Relanding #73806 [ghstack-poisoned]
**BC-breaking note**: This PR deprecates `torch.lu_solve` in favor of `torch.linalg.lu_solve_factor`. A upgrade guide is added to the documentation for `torch.lu_solve`. Note this PR DOES NOT remove `torch.lu_solve`. Relanding #73806 [ghstack-poisoned]
**BC-breaking note**: This PR deprecates `torch.lu_solve` in favor of `torch.linalg.lu_solve_factor`. A upgrade guide is added to the documentation for `torch.lu_solve`. Note this PR DOES NOT remove `torch.lu_solve`. Relanding #73806 [ghstack-poisoned]
**BC-breaking note**: This PR deprecates `torch.lu_solve` in favor of `torch.linalg.lu_solve_factor`. A upgrade guide is added to the documentation for `torch.lu_solve`. Note this PR DOES NOT remove `torch.lu_solve`. Relanding #73806 [ghstack-poisoned]
**BC-breaking note**: This PR deprecates `torch.lu_solve` in favor of `torch.linalg.lu_solve_factor`. A upgrade guide is added to the documentation for `torch.lu_solve`. Note this PR DOES NOT remove `torch.lu_solve`. Relanding #73806 [ghstack-poisoned]
**BC-breaking note**: This PR deprecates `torch.lu_solve` in favor of `torch.linalg.lu_solve_factor`. A upgrade guide is added to the documentation for `torch.lu_solve`. Note this PR DOES NOT remove `torch.lu_solve`. Relanding #73806 [ghstack-poisoned]
malfet
approved these changes
Jun 7, 2022
Collaborator
Author
|
@pytorchbot merge |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 8, 2022
Summary: **BC-breaking note**: This PR deprecates `torch.lu_solve` in favor of `torch.linalg.lu_solve_factor`. A upgrade guide is added to the documentation for `torch.lu_solve`. Note this PR DOES NOT remove `torch.lu_solve`. Pull Request resolved: #77637 Approved by: https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/c6215b343cec6a820890e5d8c1aaf3253eb3cf1a Reviewed By: osalpekar Differential Revision: D36993330 Pulled By: osalpekar fbshipit-source-id: 341d2249c26f806d318f6f4fe34d5bd851f6436d
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
**BC-breaking note**: This PR deprecates `torch.lu_solve` in favor of `torch.linalg.lu_solve_factor`. A upgrade guide is added to the documentation for `torch.lu_solve`. Note this PR DOES NOT remove `torch.lu_solve`. Pull Request resolved: pytorch#77637 Approved by: https://github.com/malfet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Relanding #73806
BC-breaking note
Deprecate
torch.lu_solvein favor oflinalg.lu_solveThe new operation has a notation consistent with
linalg.solve, and has an extra parameteradjoint=False. The update rule is as follows:Version 1.12.0
Version 1.13.0