[DO NOT REVIEW] Slow gradcheck test for forward AD gradcheck#57976
Closed
[DO NOT REVIEW] Slow gradcheck test for forward AD gradcheck#57976
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit 7104327 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
9d8f712 to
e3bb5da
Compare
e3bb5da to
a11e724
Compare
This was referenced May 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #57976 +/- ##
==========================================
+ Coverage 76.84% 76.86% +0.01%
==========================================
Files 1986 1986
Lines 197902 198029 +127
==========================================
+ Hits 152072 152209 +137
+ Misses 45830 45820 -10 |
albanD
added a commit
that referenced
this pull request
May 13, 2021
Note that this PR implements formulas only for ops that are supported by OpInfo. Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387766](https://our.internmc.facebook.com/intern/diff/D28387766) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 13, 2021
Note that this PR implements formulas only for ops that are supported by OpInfo. Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387766](https://our.internmc.facebook.com/intern/diff/D28387766) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 13, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387763](https://our.internmc.facebook.com/intern/diff/D28387763) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 13, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387763](https://our.internmc.facebook.com/intern/diff/D28387763) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 13, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 13, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 13, 2021
Note that this PR implements formulas only for ops that are supported by OpInfo. Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387766](https://our.internmc.facebook.com/intern/diff/D28387766) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 13, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387763](https://our.internmc.facebook.com/intern/diff/D28387763) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 13, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 13, 2021
Note that this PR implements formulas only for ops that are supported by OpInfo. Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387766](https://our.internmc.facebook.com/intern/diff/D28387766) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 13, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387763](https://our.internmc.facebook.com/intern/diff/D28387763) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 13, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 14, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 14, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 14, 2021
Note that this PR implements formulas only for ops that are supported by OpInfo. Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387766](https://our.internmc.facebook.com/intern/diff/D28387766) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 14, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387763](https://our.internmc.facebook.com/intern/diff/D28387763) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 14, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387763](https://our.internmc.facebook.com/intern/diff/D28387763) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 14, 2021
Note that this PR implements formulas only for ops that are supported by OpInfo. Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387766](https://our.internmc.facebook.com/intern/diff/D28387766) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 21, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 21, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387763](https://our.internmc.facebook.com/intern/diff/D28387763) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 21, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387763](https://our.internmc.facebook.com/intern/diff/D28387763) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 21, 2021
Note that this PR implements formulas only for ops that are supported by OpInfo. Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387766](https://our.internmc.facebook.com/intern/diff/D28387766) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 21, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 21, 2021
Note that this PR implements formulas only for ops that are supported by OpInfo. Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387766](https://our.internmc.facebook.com/intern/diff/D28387766) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 26, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387763](https://our.internmc.facebook.com/intern/diff/D28387763) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 26, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387763](https://our.internmc.facebook.com/intern/diff/D28387763) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 26, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
May 26, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
Jun 2, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
Jun 2, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
Jun 2, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387763](https://our.internmc.facebook.com/intern/diff/D28387763) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
Jun 2, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387763](https://our.internmc.facebook.com/intern/diff/D28387763) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
Jun 4, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
Jun 4, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
Jun 7, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
Jun 7, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
Jun 9, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
albanD
added a commit
that referenced
this pull request
Jun 9, 2021
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the slow gradcheck test for the stack: #57863
Example of the slow gradcheck before all of this stack: https://app.circleci.com/pipelines/github/pytorch/pytorch/320649/workflows/67f7f13d-c58b-4afd-96aa-8f9e08eeabcc/jobs/13385832
So the slowdown from all the extra checks is ~10min for a 4h build.