Skip to content

Codegen inplace forward AD formula from out of place one if needed#57767

Closed
albanD wants to merge 7 commits intogh/albanD/89/basefrom
gh/albanD/89/head
Closed

Codegen inplace forward AD formula from out of place one if needed#57767
albanD wants to merge 7 commits intogh/albanD/89/basefrom
gh/albanD/89/head

Conversation

@albanD
Copy link
Copy Markdown
Collaborator

@albanD albanD commented May 6, 2021 •
edited
Loading

Stack from ghstack:

Differential Revision: D28387764

@albanD albanD requested a review from soulitzer as a code owner May 6, 2021 19:54
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 6, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit dfe1586 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build test (1/1)

Step: "Test PyTorch" (full log | diagnosis details | 🔁 rerun)

2021-05-12T16:18:02.4276561Z Build left local git repository checkout dirty 
2021-05-12T16:17:55.8225986Z real	71m14.690s
2021-05-12T16:17:55.8226302Z user	121m1.919s
2021-05-12T16:17:55.8226647Z sys	27m13.761s
2021-05-12T16:17:55.8226967Z + assert_git_not_dirty
2021-05-12T16:17:55.8228114Z + [[ pytorch-linux-xenial-py3.6-gcc5.4 != *rocm* ]]
2021-05-12T16:17:55.8228950Z + [[ pytorch-linux-xenial-py3.6-gcc5.4 != *xla* ]]
2021-05-12T16:17:55.8229578Z ++ git status --porcelain
2021-05-12T16:18:02.4273921Z + git_status=' M third_party/fbgemm'
2021-05-12T16:18:02.4274882Z + [[ -n  M third_party/fbgemm ]]
2021-05-12T16:18:02.4275860Z + echo 'Build left local git repository checkout dirty'
2021-05-12T16:18:02.4276561Z Build left local git repository checkout dirty
2021-05-12T16:18:02.4277103Z + echo 'git status --porcelain:'
2021-05-12T16:18:02.4277550Z git status --porcelain:
2021-05-12T16:18:02.4277981Z + echo ' M third_party/fbgemm'
2021-05-12T16:18:02.4278332Z  M third_party/fbgemm
2021-05-12T16:18:02.4278619Z + exit 1
2021-05-12T16:18:02.4278889Z + cleanup
2021-05-12T16:18:02.4279167Z + retcode=1
2021-05-12T16:18:02.4279434Z + set +x
2021-05-12T16:18:02.4279763Z =================== sccache compilation log ===================
2021-05-12T16:18:02.4472789Z =========== If your build fails, please take a look at the log above for possible reasons ===========
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced May 6, 2021
Closed
Closed
Closed
@albanD albanD requested a review from ezyang May 6, 2021 20:47
@albanD albanD mentioned this pull request May 7, 2021
Closed
dgl-intel pushed a commit to dgl-intel/pytorch that referenced this pull request May 7, 2021
@albanD
Codegen inplace forward AD formula from out of place one if needed
b19aefe 
ghstack-source-id: e9ed998
Pull Request resolved: pytorch#57767
albanD added a commit that referenced this pull request May 10, 2021
@albanD
Codegen inplace forward AD formula from out of place one if needed
18ef8b1 
ghstack-source-id: e9ed998
Pull Request resolved: #57767
@albanD albanD mentioned this pull request May 11, 2021
Closed
albanD added a commit to albanD/pytorch that referenced this pull request May 11, 2021
@albanD
Codegen inplace forward AD formula from out of place one if needed
3e89b74 
ghstack-source-id: 193b2aa
Pull Request resolved: pytorch#57767
@albanD
Copy link
Copy Markdown
Collaborator Author

albanD commented May 12, 2021

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 13, 2021

@albanD merged this pull request in 2279962.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 13, 2021

This pull request has been reverted by 066e769.

@facebook-github-bot facebook-github-bot deleted the gh/albanD/89/head branch May 16, 2021 14:15
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
@albanD
Codegen inplace forward AD formula from out of place one if needed (p…
0432a62 
…ytorch#57767)

Summary: Pull Request resolved: pytorch#57767

Test Plan: Imported from OSS

Reviewed By: agolynski

Differential Revision: D28387764

Pulled By: albanD

fbshipit-source-id: 7bf3929dd21425be653da112385e902aa50455a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@soulitzer soulitzer Awaiting requested review from soulitzer

Assignees

No one assigned

Labels

cla signed Merged Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@albanD @facebook-github-bot @ezyang