Conversation
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 5f72973 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
[ghstack-poisoned]
[ghstack-poisoned]
|
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
|
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
| @@ -431,9 +431,11 @@ | |||
|
|
|||
| - name: cummax(Tensor self, int dim) -> (Tensor values, Tensor indices) | |||
There was a problem hiding this comment.
(note to self): here's a list of all the formulas in this diff: https://gist.github.com/zou3519/f5e818f8586854f6d018e52398920fa8
and here are a list of OpInfo tests that were modified: https://gist.github.com/zou3519/b7b4b164d3085f8f6efb22eb60a6f747
here's my progress on the review (https://docs.google.com/spreadsheets/d/14kb-3C0VLi5My8uxUa1sIMToC6pkg7GrnNG-OM4BO68/edit?usp=sharing)
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
|
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
zou3519
left a comment
There was a problem hiding this comment.
Went through the formulas, they all look correct to me. My questions are only around where the tests for ger and _index_put_impl_ are
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
|
@zou3519 this should be good to go now! |
|
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Slow gradcheck also passes for this PR and can be found here: #57976 Differential Revision: [D28387762](https://our.internmc.facebook.com/intern/diff/D28387762) [ghstack-poisoned]
|
Reverting as this PR broke some forward_mode_AD tests, e.g., https://app.circleci.com/pipelines/github/pytorch/pytorch/332766/workflows/901123bb-fbd5-48ef-b654-8e6926929c8f/jobs/13988206 |
|
This pull request has been reverted by 14f4c8d. |
Summary: Pull Request resolved: pytorch#58094 Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D28387762 Pulled By: albanD fbshipit-source-id: fc395c92af7ebb5ebae95c40f6c76273047f4097
Slow gradcheck also passes for this PR and can be found here: #57976
Stack from ghstack:
Differential Revision: D28387762