Add lint for unqualified `type: ignore` by samestep · Pull Request #56290 · pytorch/pytorch

samestep · 2021-04-16T19:52:17Z

The other half of #56272.

Test plan:

CI should pass on the tip of this PR, and we know that the lint works because the following CI runs (before this PR was finished) failed:

facebook-github-bot · 2021-04-16T19:52:24Z

💊 CI failures summary and remediations

As of commit 270a517 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

codecov · 2021-04-16T23:37:45Z

Codecov Report

Merging #56290 (e060b85) into master (0ea4eb7) will increase coverage by 0.02%.
The diff coverage is 80.58%.

❗ Current head e060b85 differs from pull request most recent head 270a517. Consider uploading reports for the commit 270a517 to get more accurate results

@@            Coverage Diff             @@
##           master   #56290      +/-   ##
==========================================
+ Coverage   77.76%   77.79%   +0.02%     
==========================================
  Files        1923     1923              
  Lines      190699   190882     +183     
==========================================
+ Hits       148298   148497     +199     
+ Misses      42401    42385      -16

facebook-github-bot · 2021-04-19T22:03:49Z

@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

samestep · 2021-04-20T15:02:36Z

@seemethere That may be something we should do, but I don't want to do that in this PR. I believe the problem is just that I removed # type: ignore comments from four lines generated by test/test_type_hints.py, so I need to figure out what mypy error code those comments were suppressing, and add them back.

Edit: Actually, I think that somehow the issue was resolved by rebasing onto a more recent master commit after #56388 was merged.

facebook-github-bot · 2021-04-20T21:21:19Z

@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

seemethere

LGTM on green

facebook-github-bot · 2021-04-21T15:00:59Z

@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-04-21T15:08:39Z

@samestep merged this pull request in 75024e2.

Summary: Followup to #56290 which adds the new lint to the local runner from #56439. Pull Request resolved: #56587 Test Plan: Same as #56439. Reviewed By: walterddr Differential Revision: D27909889 Pulled By: samestep fbshipit-source-id: 8b67f3bc36c9b5567fe5a9e49904f2cf23a9f135

Summary: This should make it easier to resolve issues surfaced by #56290. Also see #56559 (comment) for context. Pull Request resolved: #56616 Test Plan: You could add a type error in a strict-checked file like `tools/test_history.py`, and then run this command: ``` $ mypy --config=mypy-strict.ini tools/test_history.py ``` Output before this PR: ``` tools/test_history.py:13:1: error: Function is missing a type annotation for one or more arguments Found 1 error in 1 file (checked 1 source file) ``` Output after this PR: ``` tools/test_history.py:13:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def] Found 1 error in 1 file (checked 1 source file) ``` Reviewed By: driazati Differential Revision: D27918753 Pulled By: samestep fbshipit-source-id: 953926e019a7669da9004fd54498b414aec777a6

Summary: The other half of #56272. Pull Request resolved: #56290 Test Plan: CI should pass on the tip of this PR, and we know that the lint works because the following CI runs (before this PR was finished) failed: - https://github.com/pytorch/pytorch/runs/2384511062 - https://github.com/pytorch/pytorch/actions/runs/765036024 Reviewed By: seemethere Differential Revision: D27867219 Pulled By: samestep fbshipit-source-id: e648f07b6822867e70833e23ddafe7fb7eaca235

Summary: Followup to #56290 which adds the new lint to the local runner from #56439. Pull Request resolved: #56587 Test Plan: Same as #56439. Reviewed By: walterddr Differential Revision: D27909889 Pulled By: samestep fbshipit-source-id: 8b67f3bc36c9b5567fe5a9e49904f2cf23a9f135

Summary: The other half of pytorch#56272. Pull Request resolved: pytorch#56290 Test Plan: CI should pass on the tip of this PR, and we know that the lint works because the following CI runs (before this PR was finished) failed: - https://github.com/pytorch/pytorch/runs/2384511062 - https://github.com/pytorch/pytorch/actions/runs/765036024 Reviewed By: seemethere Differential Revision: D27867219 Pulled By: samestep fbshipit-source-id: e648f07b6822867e70833e23ddafe7fb7eaca235

Summary: Followup to pytorch#56290 which adds the new lint to the local runner from pytorch#56439. Pull Request resolved: pytorch#56587 Test Plan: Same as pytorch#56439. Reviewed By: walterddr Differential Revision: D27909889 Pulled By: samestep fbshipit-source-id: 8b67f3bc36c9b5567fe5a9e49904f2cf23a9f135

Summary: This should make it easier to resolve issues surfaced by pytorch#56290. Also see pytorch#56559 (comment) for context. Pull Request resolved: pytorch#56616 Test Plan: You could add a type error in a strict-checked file like `tools/test_history.py`, and then run this command: ``` $ mypy --config=mypy-strict.ini tools/test_history.py ``` Output before this PR: ``` tools/test_history.py:13:1: error: Function is missing a type annotation for one or more arguments Found 1 error in 1 file (checked 1 source file) ``` Output after this PR: ``` tools/test_history.py:13:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def] Found 1 error in 1 file (checked 1 source file) ``` Reviewed By: driazati Differential Revision: D27918753 Pulled By: samestep fbshipit-source-id: 953926e019a7669da9004fd54498b414aec777a6

Add lint for unqualified type ignore

3a1933a

facebook-github-bot added the cla signed label Apr 16, 2021

samestep added 2 commits April 19, 2021 08:39

Merge branch 'viable/strict' into lint-unqualified-type-ignore

12bcc14

Make mypy warn on unused type ignore comments

ede9d75

samestep mentioned this pull request Apr 19, 2021

Remove unused type: ignore comments #56402

Closed

samestep added 9 commits April 19, 2021 12:43

Move mypy.ini change into #56402

4e8506f

Only flag genuine # type: ignore comments

6d1b07f

Catch instances missing whitespace after colon

efc3648

Specify all error codes

f1003e8

Merge branch 'master' into lint-unqualified-type-ignore

8334a27

Fix remaining lints

00940f9

Unbreak test/test_jit.py

88b471d

Unchange the regex in torch/jit/annotations.py

948305f

Merge branch 'master' into lint-unqualified-type-ignore

2308a82

samestep marked this pull request as ready for review April 19, 2021 22:03

samestep requested review from BowenBao, H-Huang, albanD, ezyang, fmassa, jbschlosser, mingzhe09088, mrshenli, neginraoof, pritamdamania87, rohan-varma and wayi1 as code owners April 19, 2021 22:03

samestep added 3 commits April 20, 2021 08:18

Merge branch 'master' into lint-unqualified-type-ignore

0779243

Fix lint after merging

b25d355

Fix JIT tests, via line split instead of noqa

6753b1f

samestep mentioned this pull request Apr 20, 2021

[do not merge] Demo of bug in JIT parsing type ignore comments #56519

Closed

samestep added 2 commits April 20, 2021 14:16

Merge branch 'master' into lint-unqualified-type-ignore

fff9ba3

Fix lints from merge

e060b85

seemethere approved these changes Apr 20, 2021

View reviewed changes

malfet approved these changes Apr 20, 2021

View reviewed changes

samestep added 2 commits April 21, 2021 07:56

Merge branch 'master' into lint-unqualified-type-ignore

8961638

Fix lints after merging

270a517

walterddr approved these changes Apr 21, 2021

View reviewed changes

facebook-github-bot closed this in 75024e2 Apr 21, 2021

facebook-github-bot added the Merged label Apr 21, 2021

samestep deleted the lint-unqualified-type-ignore branch April 21, 2021 15:08

samestep mentioned this pull request Apr 21, 2021

Add type ignore lint to Makefile #56587

Closed

This was referenced Apr 21, 2021

Set show_error_codes = True in mypy-strict.ini #56616

Closed

Add quicklint make target #56559

Closed

samestep mentioned this pull request Apr 22, 2021

torchscript should work with type: ignore comments from mypy even if they are not at the end of the line #52271

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add lint for unqualified `type: ignore`#56290

Add lint for unqualified `type: ignore`#56290
samestep wants to merge 19 commits intopytorch:masterfrom
samestep:lint-unqualified-type-ignore

samestep commented Apr 16, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Apr 16, 2021 •

edited

Loading

Uh oh!

codecov bot commented Apr 16, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Apr 19, 2021

Uh oh!

samestep commented Apr 20, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Apr 20, 2021

Uh oh!

seemethere left a comment

Uh oh!

facebook-github-bot commented Apr 21, 2021

Uh oh!

facebook-github-bot commented Apr 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

samestep commented Apr 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Apr 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

Uh oh!

codecov bot commented Apr 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

facebook-github-bot commented Apr 19, 2021

Uh oh!

samestep commented Apr 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Apr 20, 2021

Uh oh!

seemethere left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Apr 21, 2021

Uh oh!

facebook-github-bot commented Apr 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

samestep commented Apr 16, 2021 •

edited

Loading

facebook-github-bot commented Apr 16, 2021 •

edited

Loading

codecov bot commented Apr 16, 2021 •

edited

Loading

samestep commented Apr 20, 2021 •

edited

Loading