Add type ignore lint to Makefile#56587
Closed
samestep wants to merge 1 commit intopytorch:masterfrom
samestep:type-ignore-local-lint
Closed
Add type ignore lint to Makefile#56587samestep wants to merge 1 commit intopytorch:masterfrom samestep:type-ignore-local-lint
samestep wants to merge 1 commit intopytorch:masterfrom
samestep:type-ignore-local-lint
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit a87c75f (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 2 failures tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
Contributor
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
walterddr
approved these changes
Apr 21, 2021
Contributor
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Followup to pytorch#56290 which adds the new lint to the local runner from pytorch#56439. Pull Request resolved: pytorch#56587 Test Plan: Same as pytorch#56439. Reviewed By: walterddr Differential Revision: D27909889 Pulled By: samestep fbshipit-source-id: 8b67f3bc36c9b5567fe5a9e49904f2cf23a9f135
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #56290 which adds the new lint to the local runner from #56439.
Test plan:
Same as #56439.