Set show_error_codes = True in mypy-strict.ini#56616
Closed
samestep wants to merge 1 commit intopytorch:masterfrom
samestep:mypy-strict-show-error-codes
Closed
Set show_error_codes = True in mypy-strict.ini#56616samestep wants to merge 1 commit intopytorch:masterfrom samestep:mypy-strict-show-error-codes
samestep wants to merge 1 commit intopytorch:masterfrom
samestep:mypy-strict-show-error-codes
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit ea8376d (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
driazati
approved these changes
Apr 21, 2021
Contributor
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: This should make it easier to resolve issues surfaced by pytorch#56290. Also see pytorch#56559 (comment) for context. Pull Request resolved: pytorch#56616 Test Plan: You could add a type error in a strict-checked file like `tools/test_history.py`, and then run this command: ``` $ mypy --config=mypy-strict.ini tools/test_history.py ``` Output before this PR: ``` tools/test_history.py:13:1: error: Function is missing a type annotation for one or more arguments Found 1 error in 1 file (checked 1 source file) ``` Output after this PR: ``` tools/test_history.py:13:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def] Found 1 error in 1 file (checked 1 source file) ``` Reviewed By: driazati Differential Revision: D27918753 Pulled By: samestep fbshipit-source-id: 953926e019a7669da9004fd54498b414aec777a6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make it easier to resolve issues surfaced by #56290. Also see #56559 (comment) for context.
Test plan:
You could add a type error in a strict-checked file like
tools/test_history.py, and then run this command:Output before this PR:
Output after this PR: