[caffe2] add a CAFFE2_NODISCARD macro to help support old compilers#53754
Closed
simpkins wants to merge 1 commit intogh/simpkins/10/basefrom
Closed
[caffe2] add a CAFFE2_NODISCARD macro to help support old compilers#53754simpkins wants to merge 1 commit intogh/simpkins/10/basefrom
simpkins wants to merge 1 commit intogh/simpkins/10/basefrom
Conversation
Some of the PyTorch CircleCI builds still use gcc 5.4, and compile with `-Werror=attributes` causing this old compiler to fail because it does not understand the `[[nodiscard]]` attribute. Let's define a `CAFFE2_NODISCARD` macro to work around this. Differential Revision: [D26959584](https://our.internmc.facebook.com/intern/diff/D26959584/) [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit e7a7424 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Mar 10, 2021
Contributor
|
This pull request has been merged in 91531d3. |
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
…ytorch#53754) Summary: Pull Request resolved: pytorch#53754 Some of the PyTorch CircleCI builds still use gcc 5.4, and compile with `-Werror=attributes` causing this old compiler to fail because it does not understand the `[[nodiscard]]` attribute. Let's define a `CAFFE2_NODISCARD` macro to work around this. ghstack-source-id: 123594084 Test Plan: I'm using this macro in subsequent diffs in the stack. Reviewed By: mraway Differential Revision: D26959584 fbshipit-source-id: c7ba94f7ea944b6340e9fe20949ba41931e11d41
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…ytorch#53754) Summary: Pull Request resolved: pytorch#53754 Some of the PyTorch CircleCI builds still use gcc 5.4, and compile with `-Werror=attributes` causing this old compiler to fail because it does not understand the `[[nodiscard]]` attribute. Let's define a `CAFFE2_NODISCARD` macro to work around this. ghstack-source-id: 123594084 Test Plan: I'm using this macro in subsequent diffs in the stack. Reviewed By: mraway Differential Revision: D26959584 fbshipit-source-id: c7ba94f7ea944b6340e9fe20949ba41931e11d41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Some of the PyTorch CircleCI builds still use gcc 5.4, and compile with
-Werror=attributescausing this old compiler to fail because it does notunderstand the
[[nodiscard]]attribute.Let's define a
CAFFE2_NODISCARDmacro to work around this.Differential Revision: D26959584