[caffe2] add a SerializationOptions field for the save operator#53402
Closed
simpkins wants to merge 2 commits intogh/simpkins/5/basefrom
Closed
[caffe2] add a SerializationOptions field for the save operator#53402simpkins wants to merge 2 commits intogh/simpkins/5/basefrom
simpkins wants to merge 2 commits intogh/simpkins/5/basefrom
Conversation
Add an `options` field to the `Save` operator which accepts options for how to serialize different blobs. At the moment this simply allows controlling the existing `chunk_size` behavior, but in the future we can add other options, such as the ability to control compression settings or other serialization formats. Differential Revision: [D26502577](https://our.internmc.facebook.com/intern/diff/D26502577/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D26502577/)! [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 1402a2c (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Mar 5, 2021
…rator" Add an `options` field to the `Save` operator which accepts options for how to serialize different blobs. At the moment this simply allows controlling the existing `chunk_size` behavior, but in the future we can add other options, such as the ability to control compression settings or other serialization formats. Differential Revision: [D26502577](https://our.internmc.facebook.com/intern/diff/D26502577/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D26502577/)! [ghstack-poisoned]
This was referenced Mar 10, 2021
Contributor
|
This pull request has been merged in 7e5ffbf. |
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
…rch#53402) Summary: Pull Request resolved: pytorch#53402 Add an `options` field to the `Save` operator which accepts options for how to serialize different blobs. At the moment this simply allows controlling the existing `chunk_size` behavior, but in the future we can add other options, such as the ability to control compression settings or other serialization formats. ghstack-source-id: 123567034 Test Plan: Added a new test to `load_save_test.py` that passes in options and verifies that blobs were serialized with the expected number of chunks. buck test caffe2/caffe2:caffe2_test_cpu \ caffe2/caffe2/core:serialization_test \ caffe2/caffe2/python/operator_test:load_save_test Reviewed By: mraway Differential Revision: D26502577 fbshipit-source-id: 6e302e530bb96990517c2e35c505db7f14a56284
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…rch#53402) Summary: Pull Request resolved: pytorch#53402 Add an `options` field to the `Save` operator which accepts options for how to serialize different blobs. At the moment this simply allows controlling the existing `chunk_size` behavior, but in the future we can add other options, such as the ability to control compression settings or other serialization formats. ghstack-source-id: 123567034 Test Plan: Added a new test to `load_save_test.py` that passes in options and verifies that blobs were serialized with the expected number of chunks. buck test caffe2/caffe2:caffe2_test_cpu \ caffe2/caffe2/core:serialization_test \ caffe2/caffe2/python/operator_test:load_save_test Reviewed By: mraway Differential Revision: D26502577 fbshipit-source-id: 6e302e530bb96990517c2e35c505db7f14a56284
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Add an
optionsfield to theSaveoperator which accepts options for how toserialize different blobs. At the moment this simply allows controlling the
existing
chunk_sizebehavior, but in the future we can add other options,such as the ability to control compression settings or other serialization
formats.
Differential Revision: D26502577
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!