[caffe2] update load_save_test.py to also verify the chunking behavior#53401
Closed
simpkins wants to merge 2 commits intogh/simpkins/4/basefrom
Closed
[caffe2] update load_save_test.py to also verify the chunking behavior#53401simpkins wants to merge 2 commits intogh/simpkins/4/basefrom
simpkins wants to merge 2 commits intogh/simpkins/4/basefrom
Conversation
This is a reland of D26641599 after rebasing onto D26802576. Add some small utility functions to read the blob names back from the minidb file so that we can verify how many chunks were written for each blob. Differential Revision: [D26853942](https://our.internmc.facebook.com/intern/diff/D26853942/) [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 3815beb (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Mar 5, 2021
…ing behavior" This is a reland of D26641599 after rebasing onto D26802576. Add some small utility functions to read the blob names back from the minidb file so that we can verify how many chunks were written for each blob. Differential Revision: [D26853942](https://our.internmc.facebook.com/intern/diff/D26853942/) [ghstack-poisoned]
This was referenced Mar 10, 2021
Codecov Report
@@ Coverage Diff @@
## gh/simpkins/4/base #53401 +/- ##
======================================================
- Coverage 77.63% 77.63% -0.01%
======================================================
Files 1869 1869
Lines 182377 182377
======================================================
- Hits 141594 141593 -1
- Misses 40783 40784 +1 |
Contributor
|
This pull request has been merged in 023948e. |
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
pytorch#53401) Summary: Pull Request resolved: pytorch#53401 This is a reland of D26641599 (pytorch@cd9ac54) after rebasing onto D26802576 (pytorch@f595ba1). Add some small utility functions to read the blob names back from the minidb file so that we can verify how many chunks were written for each blob. ghstack-source-id: 123567033 Test Plan: buck test caffe2/caffe2/python/operator_test:load_save_test Reviewed By: mraway Differential Revision: D26853942 fbshipit-source-id: 0b45078fdd279f547752c8fdb771e296374a00da
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
pytorch#53401) Summary: Pull Request resolved: pytorch#53401 This is a reland of D26641599 (pytorch@6f589c9) after rebasing onto D26802576 (pytorch@2fad0d9). Add some small utility functions to read the blob names back from the minidb file so that we can verify how many chunks were written for each blob. ghstack-source-id: 123567033 Test Plan: buck test caffe2/caffe2/python/operator_test:load_save_test Reviewed By: mraway Differential Revision: D26853942 fbshipit-source-id: 0b45078fdd279f547752c8fdb771e296374a00da
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This is a reland of D26641599 after rebasing onto D26802576.
Add some small utility functions to read the blob names back from the minidb
file so that we can verify how many chunks were written for each blob.
Differential Revision: D26853942