WIP: Support strided convolutions with padding='same' by peterbell10 · Pull Request #52631 · pytorch/pytorch

peterbell10 · 2021-02-22T22:07:27Z

Stack from ghstack:

WIP: Support strided convolutions with padding='same' #52631 WIP: Support strided convolutions with padding='same'
Use asymmetric mkldnn convolutions for padding='same' convolutions #45668 Use asymmetric mkldnn convolutions for padding='same' convolutions
Add padding='same' mode to conv{1,2,3}d #45667 Add padding='same' mode to conv{1,2,3}d

[ghstack-poisoned]

ghstack-source-id: 969e9f2 Pull Request resolved: #52631

facebook-github-bot · 2021-02-22T22:07:52Z

💊 CI failures summary and remediations

As of commit 9be60c9 (more details on the Dr. CI page):

6/6 failures introduced in this PR

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_bionic_py3_8_gcc9_coverage_test2 (1/3)

Step: "Set Up CI Environment After attach_workspace" (full log | diagnosis details | 🔁 rerun)

E: Unable to locate package expect-dev

E: Unable to locate package expect-dev
+ sudo apt-get -y install moreutils expect-dev

Reading package lists... 0%

Reading package lists... 100%

Reading package lists... Done


Building dependency tree... 0%

Building dependency tree... 0%

Building dependency tree... 50%

Building dependency tree... 50%

Building dependency tree       


Reading state information... 0%

Reading state information... 0%

Reading state information... Done

Package moreutils is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'moreutils' has no installation candidate
E: Unable to locate package expect-dev


Exited with code exit status 100

CONTAINER ID        NAME                CPU %               MEM USAGE / LIMIT   MEM %               NET I/O             BLOCK I/O           PIDS
/bin/bash: line 18: unbuffer: command not found
/bin/bash: line 18: ts: command not found


Exited with code exit status 127

pytorch_linux_xenial_py3_clang7_onnx_ort_test2 (2/3)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Mar 17 16:40:06 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_mask_rcnn FAILED [ 67%]

Mar 17 16:39:48 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_lstm_unilayer_forward_no_initial_state_without_sequence_lengths_with_dropout PASSED [ 65%]
Mar 17 16:39:48 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_lstm_unilayer_forward_no_initial_state_without_sequence_lengths_without_dropout PASSED [ 66%]
Mar 17 16:39:48 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_lstm_unilayer_forward_with_initial_state_with_batch_first_sequence_lengths_with_dropout PASSED [ 66%]
Mar 17 16:39:48 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_lstm_unilayer_forward_with_initial_state_with_batch_first_sequence_lengths_without_dropout PASSED [ 66%]
Mar 17 16:39:48 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_lstm_unilayer_forward_with_initial_state_with_variable_length_sequences_with_dropout PASSED [ 66%]
Mar 17 16:39:48 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_lstm_unilayer_forward_with_initial_state_with_variable_length_sequences_without_dropout PASSED [ 66%]
Mar 17 16:39:48 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_lstm_unilayer_forward_with_initial_state_without_sequence_lengths_with_dropout PASSED [ 66%]
Mar 17 16:39:48 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_lstm_unilayer_forward_with_initial_state_without_sequence_lengths_without_dropout PASSED [ 66%]
Mar 17 16:39:49 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_lt PASSED [ 67%]
Mar 17 16:39:49 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_lt_scalar PASSED [ 67%]
Mar 17 16:40:06 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_mask_rcnn FAILED [ 67%]
Mar 17 16:40:06 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_masked_fill PASSED [ 67%]
Mar 17 16:40:06 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_masked_fill_inplace PASSED [ 67%]
Mar 17 16:40:06 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_masked_scatter PASSED [ 67%]
Mar 17 16:40:06 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_masked_select PASSED [ 68%]
Mar 17 16:40:06 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_matmul PASSED [ 68%]
Mar 17 16:40:06 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_matmul_batch PASSED [ 68%]
Mar 17 16:40:06 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_max_tensors PASSED [ 68%]
Mar 17 16:40:06 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_maxpool PASSED [ 68%]
Mar 17 16:40:06 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_maxpool_1d_ceil PASSED [ 68%]
Mar 17 16:40:06 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset13::test_maxpool_2d PASSED [ 69%]

docker-pytorch-linux-xenial-py3.6-gcc7 (3/3)

Step: "Check if image should be built" (full log | diagnosis details | 🔁 rerun)

ERROR: Something has gone wrong and the previous image isn't available for the merge-base of your branch

+ docker manifest inspect 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-xenial-py3.6-gcc7:9e4caef77adcb160c0d1799dfa17cdd984106e12
unsupported manifest format: &{{{2 application/vnd.docker.distribution.manifest.v2+json} {application/vnd.docker.container.image.v1+json 23205 sha256:6e1c776af5bfa292b02341d7d918a576fe57f4fc8c4f372c22ef5ce780f0f38d [] map[] <nil>} [{application/vnd.docker.image.rootfs.diff.tar.gzip 45962352 sha256:4007a89234b4f56c03e6831dc220550d2e5fba935d9f5f5bcea64857ac4f4888 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 852 sha256:5dfa26c6b9c9d1ccbcb1eaa65befa376805d9324174ac580ca76fdedc3575f54 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 527 sha256:0ba7bf18aa406cb7dc372ac732de222b04d1c824ff1705d8900831c3d1361ff5 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 169 sha256:4c6ec688ebe374ea7d89ce967576d221a177ebd2c02ca9f053197f954102e30b [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 1385 sha256:a297e9a57cca29bea95054e86295ef3c89e469a97bd98c321a44a4eee504259f [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 236620202 sha256:1835c4f2d19d87948f9319c14bd29b3b465183fd4e58c512948b063e0aa70780 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 807 sha256:8c2c171181986708d4bb1f62c718591e483f860a93d052765408891feb1fbb80 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 106 sha256:24904ea982b8ac8d6943cb3774fe99c5e0cd79307498e8ec6c7d920747bae6d3 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 405 sha256:40cceba3205b9f968028e1eff378ff10c06ef5c82378a1fd499ef17aa7470ab6 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 32 sha256:4f4fb700ef54461cfa02571ae0db9a0dc1e0cdb5577484a6d75e68dc38e8acc1 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 107 sha256:4ca8b18954bb434ae14b3023d19b3fa330339b0e9fb4a58d72d5c567d77f3853 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 360 sha256:09d23f18008416232ef0f41ceb68300f9650fd6c0b9ae0121bdf58c1a79f5ac5 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 1154 sha256:c1f57f10c2348dd6a96f43e191d687b3bd1b2119c33d01d55f60130f9d7db575 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 405 sha256:ddc03e0565600a84a96ca1acaef16d901546cec059a9b56328b7d314c68ba0b8 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 106 sha256:ff20d033ca67e9e3abc50fe735dac5083decfcc786ff9261347917d54047c13b [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 1839 sha256:0a7be0d99e2845e596a3adefaf3ea9a5206ea1b53b6d4e01f7f3b078b2c44144 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 1193563018 sha256:6a0afa43d1889c87655cb1c286fbcc4814aec1bd7fe5069811fa2a6789bd7735 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 438 sha256:442a2db26d83d0531c4f4d5be7b271b9f19f41dc8a72c94181991d10f80223c6 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 47114037 sha256:dde8a3489997188dbcebd3927402c8aada44bd09101ef9e6de3330f9d6680cd0 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 228 sha256:2c62d66c8087c5f63aa2f1b7c26b6d94c08e1a82ad44da11e1f97970a3b7b9b7 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 952889 sha256:f15b3507f75735fe17605b91c2b639898acb962a2b5b9b9d37f24eec460a84cf [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 913 sha256:c587c4489bd664b701a0cbf101f9e889fbd2af09fbf7b0d623cece3fc976ab4e [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 1999293 sha256:2607c4a940e56ea857b286ca52f34e01fa7b537c0a2129f30d869a4a76da3b4f [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 109 sha256:0587248c03ff966548ed9259c1c1c86581cebb8d4367c3d0e70a8b7fff97b4bd [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 874 sha256:0fa5623010ce036e54cee83b5674af89d1d8e2915e37e365816f1923a82f6f9c [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 981122 sha256:f173458b7fd58a218c6310403d1d2599120e8860d86a4bc47ee781109f867591 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 103 sha256:919bbc8473c74eb65e8455ded2048a69512329079bb1c452e0c825bacf5fb849 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 859 sha256:2ce22009bfc1fafa1f09344c7e0bccd64e35a60a17a46e533ced6053a631b164 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 97109609 sha256:a75377cdc0e30bfda59bb0bf0751efb4c30e5a9a545a7abfd45643ac9fd956ad [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 105 sha256:1b38180be21abb230216acab269f18a69b747d1bdcf80fa6d668a7844c1cfb03 [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 1292 sha256:31e192ef4ca55c80d50e29a6aded7109ded8fa0fca1b8120aa502b5b4fa11e2e [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 149 sha256:f919644e3f104f91eaa866a95463cc35f14598254a18a1ff4a062b935a0be9bd [] map[] <nil>} {application/vnd.docker.image.rootfs.diff.tar.gzip 641 sha256:5fda01445c5c1abf30e478cde41c66966e160fcd271cf3d4d8a4034b6c8b4aaa [] map[] <nil>} {applica
++ git merge-base HEAD 53af49b8aac22bc7d125ca7736417ff02d889f23
+ git rev-parse 53af49b8aac22bc7d125ca7736417ff02d889f23:.circleci/docker
9e4caef77adcb160c0d1799dfa17cdd984106e12
+++ git merge-base HEAD 53af49b8aac22bc7d125ca7736417ff02d889f23
++ git rev-parse 53af49b8aac22bc7d125ca7736417ff02d889f23:.circleci/docker
+ PREVIOUS_DOCKER_TAG=9e4caef77adcb160c0d1799dfa17cdd984106e12
+ [[ 9e4caef77adcb160c0d1799dfa17cdd984106e12 = \9\e\4\c\a\e\f\7\7\a\d\c\b\1\6\0\c\0\d\1\7\9\9\d\f\a\1\7\c\d\d\9\8\4\1\0\6\e\1\2 ]]
+ echo 'ERROR: Something has gone wrong and the previous image isn'\''t available for the merge-base of your branch'
ERROR: Something has gone wrong and the previous image isn't available for the merge-base of your branch
+ echo '       contact the PyTorch team to restore the original images'
       contact the PyTorch team to restore the original images
+ exit 1


Exited with code exit status 1

3 failures not recognized by patterns:

Job	Step	Action
^{pytorch_windows_vs2019_py36_cuda10.1_test2}	^Test	🔁 rerun
^{pytorch_windows_vs2019_py36_cuda10.1_test1}	^{Checkout code}	🔁 rerun
^{pytorch_linux_bionic_py3_8_gcc9_coverage_test1}	^{Checkout code}	🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

[ghstack-poisoned]

ghstack-source-id: 039f3e7 Pull Request resolved: #52631

[ghstack-poisoned]

ghstack-source-id: 039f3e7 Pull Request resolved: #52631

ghstack-source-id: 039f3e7 Pull Request resolved: pytorch#52631

[ghstack-poisoned]

ghstack-source-id: f71fdc4 Pull Request resolved: #52631

jbschlosser · 2021-03-19T14:37:08Z

To get the conversation going, I propose the following variations for stride > 1:

padding=same
- Non-input-size dependent approach
- total_padding = dilation * (kernelSize - 1)
padding=same_minimal (with doc warnings explaining the downsides)
- TF's input-size-dependent approach that minimizes the total padding
- total_padding = max(0, dilation * (kernel_size - 1) - (input_size - 1) % stride)

pytorchbot · 2022-04-12T05:05:20Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
Stale pull requests will automatically be closed 30 days after being marked Stale

WIP: Support strided convolutions with padding='same'

879e2b7

[ghstack-poisoned]

peterbell10 requested a review from glaringlee as a code owner February 22, 2021 22:07

This was referenced Feb 22, 2021

Add padding='same' mode to conv{1,2,3}d #45667

Closed

Use asymmetric mkldnn convolutions for padding='same' convolutions #45668

Closed

peterbell10 added a commit that referenced this pull request Feb 22, 2021

WIP: Support strided convolutions with padding='same'

1ddd67c

ghstack-source-id: 969e9f2 Pull Request resolved: #52631

facebook-github-bot added the cla signed label Feb 22, 2021

peterbell10 marked this pull request as draft February 22, 2021 22:07

pytorchbot added the open source label Feb 22, 2021

Update on "WIP: Support strided convolutions with padding='same'"

2666a9d

[ghstack-poisoned]

Update on "WIP: Support strided convolutions with padding='same'"

4b04b92

[ghstack-poisoned]

peterbell10 added a commit that referenced this pull request Mar 11, 2021

WIP: Support strided convolutions with padding='same'

68a8da5

ghstack-source-id: 039f3e7 Pull Request resolved: #52631

Update on "WIP: Support strided convolutions with padding='same'"

c7b6109

[ghstack-poisoned]

Update on "WIP: Support strided convolutions with padding='same'"

70bb385

[ghstack-poisoned]

peterbell10 added a commit that referenced this pull request Mar 15, 2021

WIP: Support strided convolutions with padding='same'

51796e1

ghstack-source-id: 039f3e7 Pull Request resolved: #52631

peterbell10 added a commit to peterbell10/pytorch that referenced this pull request Mar 15, 2021

WIP: Support strided convolutions with padding='same'

8c5cceb

ghstack-source-id: 039f3e7 Pull Request resolved: pytorch#52631

Update on "WIP: Support strided convolutions with padding='same'"

9be60c9

[ghstack-poisoned]

peterbell10 added a commit that referenced this pull request Mar 17, 2021

WIP: Support strided convolutions with padding='same'

98dec34

ghstack-source-id: f71fdc4 Pull Request resolved: #52631

mruberry requested a review from jbschlosser January 25, 2022 06:18

pytorchbot added the Stale label Apr 12, 2022

github-actions bot closed this May 12, 2022

facebook-github-bot deleted the gh/peterbell10/53/head branch June 11, 2022 14:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Support strided convolutions with padding='same'#52631

WIP: Support strided convolutions with padding='same'#52631
peterbell10 wants to merge 6 commits intogh/peterbell10/53/basefrom
gh/peterbell10/53/head

peterbell10 commented Feb 22, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Feb 22, 2021 •

edited

Loading

Uh oh!

jbschlosser commented Mar 19, 2021

Uh oh!

pytorchbot commented Apr 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

peterbell10 commented Feb 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Feb 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 3 new failures recognized by patterns

pytorch_linux_bionic_py3_8_gcc9_coverage_test2 (1/3)

pytorch_linux_xenial_py3_clang7_onnx_ort_test2 (2/3)

docker-pytorch-linux-xenial-py3.6-gcc7 (3/3)

3 failures not recognized by patterns:

Uh oh!

jbschlosser commented Mar 19, 2021

Uh oh!

pytorchbot commented Apr 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

peterbell10 commented Feb 22, 2021 •

edited

Loading

facebook-github-bot commented Feb 22, 2021 •

edited

Loading