Skip to content

Use asymmetric mkldnn convolutions for padding='same' convolutions#45668

Closed
peterbell10 wants to merge 19 commits intogh/peterbell10/18/basefrom
gh/peterbell10/18/head
Closed

Use asymmetric mkldnn convolutions for padding='same' convolutions#45668
peterbell10 wants to merge 19 commits intogh/peterbell10/18/basefrom
gh/peterbell10/18/head

Conversation

@peterbell10
Copy link
Copy Markdown
Collaborator

@peterbell10 peterbell10 commented Oct 1, 2020

Stack from ghstack:

peterbell10 added a commit that referenced this pull request Oct 1, 2020
peterbell10 added a commit that referenced this pull request Oct 1, 2020
peterbell10 added a commit that referenced this pull request Oct 1, 2020
@mrshenli mrshenli added module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration module: nn Related to torch.nn module: convolution Problems related to convolutions (THNN, THCUNN, CuDNN) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Oct 1, 2020
@mrshenli mrshenli requested a review from gchanan October 1, 2020 23:57
peterbell10 added a commit that referenced this pull request Oct 5, 2020
peterbell10 added a commit to peterbell10/pytorch that referenced this pull request Oct 5, 2020
peterbell10 added a commit that referenced this pull request Oct 5, 2020
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @peterbell10!

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but we do not have a signature on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

peterbell10 added a commit that referenced this pull request Feb 17, 2021
peterbell10 added a commit that referenced this pull request Feb 20, 2021
peterbell10 added a commit to peterbell10/pytorch that referenced this pull request Mar 11, 2021
peterbell10 added a commit to peterbell10/pytorch that referenced this pull request Mar 15, 2021
@peterbell10 peterbell10 requested a review from mruberry April 23, 2021 19:53
@mruberry
Copy link
Copy Markdown
Collaborator

@ngimel @jbschlosser are you two the correct reviewers for this?

@mruberry mruberry requested review from jbschlosser and removed request for albanD, gchanan, mruberry and soulitzer January 24, 2022 17:03
@mruberry
Copy link
Copy Markdown
Collaborator

Updating reviewers since it looks like this PR was lost in the shuffle

@jbschlosser
Copy link
Copy Markdown
Contributor

I'm good to review this, but do you mind rebasing please? @peterbell10 Might be a bit tricky due to the large convolution changes I landed recently.

@pytorchbot
Copy link
Copy Markdown
Collaborator

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
Stale pull requests will automatically be closed 30 days after being marked Stale

@github-actions github-actions bot closed this May 12, 2022
@facebook-github-bot facebook-github-bot deleted the gh/peterbell10/18/head branch June 11, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed module: convolution Problems related to convolutions (THNN, THCUNN, CuDNN) module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration module: nn Related to torch.nn open source Stale triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants