Skip to content

[quant][graphmode][fx] Add support for functional conv1d and conv3d#51155

Closed
jerryzh168 wants to merge 2 commits intogh/jerryzh168/534/basefrom
gh/jerryzh168/534/head
Closed

[quant][graphmode][fx] Add support for functional conv1d and conv3d#51155
jerryzh168 wants to merge 2 commits intogh/jerryzh168/534/basefrom
gh/jerryzh168/534/head

Conversation

@jerryzh168
Copy link
Copy Markdown
Contributor

@jerryzh168 jerryzh168 commented Jan 26, 2021 •
edited
Loading

Stack from ghstack:

Summary:
This PR added support for quantizing functional conv1d, conv3d, conv1d_relu and conv3d_relu

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_functional_conv

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D26089965

@jerryzh168
[quant][graphmode][fx] Add support for functional conv1d and conv3d
aef8467 
Summary:
This PR added support for quantizing functional conv1d, conv3d,  conv1d_relu and conv3d_relu

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_functional_conv

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168 jerryzh168 mentioned this pull request Jan 26, 2021
Closed
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 26, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 83c0bee (more details on the Dr. CI page):

  • 2/7 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)
  • 5/7 broken upstream at merge base 1ee5d11 on Jan 26 from 12:49pm to 7:04pm

🚧 5 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

Extra GitHub checks: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@jerryzh168
Update on "[quant][graphmode][fx] Add support for functional conv1d a…
83c0bee 
…nd conv3d"

Summary:
This PR added support for quantizing functional conv1d, conv3d,  conv1d_relu and conv3d_relu

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_functional_conv

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D26089965](https://our.internmc.facebook.com/intern/diff/D26089965)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jan 27, 2021
@jerryzh168
[quant][graphmode][fx] Add support for functional conv1d and conv3d
c3f1592 
Summary:
This PR added support for quantizing functional conv1d, conv3d,  conv1d_relu and conv3d_relu

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_functional_conv

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 836346b
Pull Request resolved: #51155
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 27, 2021

This pull request has been merged in dd1a97b.

@mruberry
Copy link
Copy Markdown
Collaborator

mruberry commented Jan 27, 2021

Unlanding. This broke several builds, as its Github CI indicates. Sample failure:

test_run_mypy [mypy.ini] - TestTypeHints
test_type_hints.py

Traceback (most recent call last):
  File "test_type_hints.py", line 171, in test_run_mypy
    self.fail(f"mypy failed: {stdout} {stderr}")
AssertionError: mypy failed: torch/quantization/fx/utils.py:206: error: Incompatible return value type (got "Optional[Any]", expected "Callable[..., Any]")  [return-value]
Found 1 error in 1 file (checked 1211 source files)

@mruberry mruberry reopened this Jan 27, 2021
@jerryzh168 jerryzh168 mentioned this pull request Jan 28, 2021
Closed
jerryzh168 added a commit that referenced this pull request Jan 28, 2021
@jerryzh168
[quant][graphmode][fx] Add support for functional conv1d and conv3d (#…
1ccf7b7 
…51155)

Summary:
This PR added support for quantizing functional conv1d, conv3d,  conv1d_relu and conv3d_relu

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_functional_conv

Reviewed By: vkuzo

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jan 28, 2021
@jerryzh168
[quant][graphmode][fx] Add support for functional conv1d and conv3d (#…
181f1ec 
…51155)

Summary:
This PR added support for quantizing functional conv1d, conv3d,  conv1d_relu and conv3d_relu

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_functional_conv

Reviewed By: vkuzo

ghstack-source-id: a2c4439
Pull Request resolved: #51254
@jerryzh168
Copy link
Copy Markdown
Contributor Author

jerryzh168 commented Jan 28, 2021

will reland in #51254

@jerryzh168 jerryzh168 closed this Jan 28, 2021
jerryzh168 added a commit that referenced this pull request Jan 28, 2021
@jerryzh168
Update on "[reland][quant][graphmode][fx] Add support for functional …
1616286 
…conv1d and conv3d (#51155)"

Summary:
This PR added support for quantizing functional conv1d, conv3d,  conv1d_relu and conv3d_relu

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_functional_conv

Reviewed By: vkuzo

Differential Revision: [D26116172](https://our.internmc.facebook.com/intern/diff/D26116172)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jan 28, 2021
@jerryzh168
[quant][graphmode][fx] Add support for functional conv1d and conv3d (#…
1e59499 
…51155)

Summary:
This PR added support for quantizing functional conv1d, conv3d,  conv1d_relu and conv3d_relu

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_functional_conv

Reviewed By: vkuzo

ghstack-source-id: 8537b36
Pull Request resolved: #51254
facebook-github-bot pushed a commit that referenced this pull request Jan 28, 2021
@jerryzh168 @facebook-github-bot
[quant][graphmode][fx] Add support for functional conv1d and conv3d (#…
7097c0d 
…51155) (#51254)

Summary:
Pull Request resolved: #51254

This PR added support for quantizing functional conv1d, conv3d,  conv1d_relu and conv3d_relu

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_functional_conv

Imported from OSS

Reviewed By: vkuzo

Differential Revision: D26116172

fbshipit-source-id: 56e7d799c11963fe59ee3a1b6eb23f52007b91dc
@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/534/head branch January 31, 2021 15:18
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@jerryzh168 @facebook-github-bot
[quant][graphmode][fx] Add support for functional conv1d and conv3d (p…
c431e83 
…ytorch#51155)

Summary:
Pull Request resolved: pytorch#51155

This PR added support for quantizing functional conv1d, conv3d,  conv1d_relu and conv3d_relu

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_functional_conv

Imported from OSS

Reviewed By: vkuzo

Differential Revision: D26089965

fbshipit-source-id: 4aea507d05b744807e993f6d3711ab308fb7591b
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@jerryzh168 @facebook-github-bot
[quant][graphmode][fx] Add support for functional conv1d and conv3d (p…
b74b648 
…ytorch#51155) (pytorch#51254)

Summary:
Pull Request resolved: pytorch#51254

This PR added support for quantizing functional conv1d, conv3d,  conv1d_relu and conv3d_relu

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_functional_conv

Imported from OSS

Reviewed By: vkuzo

Differential Revision: D26116172

fbshipit-source-id: 56e7d799c11963fe59ee3a1b6eb23f52007b91dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuzo vkuzo vkuzo approved these changes

@raghuramank100 raghuramank100 Awaiting requested review from raghuramank100

@supriyar supriyar Awaiting requested review from supriyar

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jerryzh168 @facebook-github-bot @mruberry @vkuzo