Skip to content

[reland][quant][graphmode][fx] Add support for functional conv1d and conv3d (#51155)#51254

Closed
jerryzh168 wants to merge 2 commits intogh/jerryzh168/535/basefrom
gh/jerryzh168/535/head
Closed

[reland][quant][graphmode][fx] Add support for functional conv1d and conv3d (#51155)#51254
jerryzh168 wants to merge 2 commits intogh/jerryzh168/535/basefrom
gh/jerryzh168/535/head

Conversation

@jerryzh168
Copy link
Copy Markdown
Contributor

@jerryzh168 jerryzh168 commented Jan 28, 2021

Stack from ghstack:

Summary:
This PR added support for quantizing functional conv1d, conv3d, conv1d_relu and conv3d_relu

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_functional_conv

Reviewed By: vkuzo

Differential Revision: D26116172

…51155)

Summary:
This PR added support for quantizing functional conv1d, conv3d,  conv1d_relu and conv3d_relu

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_functional_conv

Reviewed By: vkuzo

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jan 28, 2021
…51155)

Summary:
This PR added support for quantizing functional conv1d, conv3d,  conv1d_relu and conv3d_relu

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_functional_conv

Reviewed By: vkuzo

ghstack-source-id: a2c4439
Pull Request resolved: #51254
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 28, 2021

💊 CI failures summary and remediations

As of commit 1616286 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@jerryzh168 jerryzh168 changed the title [quant][graphmode][fx] Add support for functional conv1d and conv3d (#51155) [reland][quant][graphmode][fx] Add support for functional conv1d and conv3d (#51155) Jan 28, 2021
…conv1d and conv3d (#51155)"

Summary:
This PR added support for quantizing functional conv1d, conv3d,  conv1d_relu and conv3d_relu

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_functional_conv

Reviewed By: vkuzo

Differential Revision: [D26116172](https://our.internmc.facebook.com/intern/diff/D26116172)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jan 28, 2021
…51155)

Summary:
This PR added support for quantizing functional conv1d, conv3d,  conv1d_relu and conv3d_relu

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_functional_conv

Reviewed By: vkuzo

ghstack-source-id: 8537b36
Pull Request resolved: #51254
@jerryzh168 jerryzh168 requested a review from vkuzo January 28, 2021 21:51
Copy link
Copy Markdown
Contributor

@vkuzo vkuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reland stamp

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 28, 2021

Codecov Report

Merging #51254 (1616286) into gh/jerryzh168/535/base (cc211bb) will decrease coverage by 0.31%.
The diff coverage is 100.00%.

@@                    Coverage Diff                     @@
##           gh/jerryzh168/535/base   #51254      +/-   ##
==========================================================
- Coverage                   80.85%   80.53%   -0.32%     
==========================================================
  Files                        1931     1931              
  Lines                      210932   210951      +19     
==========================================================
- Hits                       170542   169889     -653     
- Misses                      40390    41062     +672     

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 7097c0d.

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/535/head branch February 1, 2021 15:19
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
…ytorch#51155) (pytorch#51254)

Summary:
Pull Request resolved: pytorch#51254

This PR added support for quantizing functional conv1d, conv3d,  conv1d_relu and conv3d_relu

Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_functional_conv

Imported from OSS

Reviewed By: vkuzo

Differential Revision: D26116172

fbshipit-source-id: 56e7d799c11963fe59ee3a1b6eb23f52007b91dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants