[quant][graphmode][fx] Add functional conv2d + relu#51079
Closed
jerryzh168 wants to merge 4 commits intogh/jerryzh168/533/basefrom
Closed
[quant][graphmode][fx] Add functional conv2d + relu#51079jerryzh168 wants to merge 4 commits intogh/jerryzh168/533/basefrom
jerryzh168 wants to merge 4 commits intogh/jerryzh168/533/basefrom
Conversation
Summary: Added support for functional conv2d + relu, will add conv1d and conv3d in future PR Test Plan: python test/test_quantization.py TestQuantizeFxOps.test_functional_conv Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 1ee5d11 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Summary: Added support for functional conv2d + relu, will add conv1d and conv3d in future PR Test Plan: python test/test_quantization.py TestQuantizeFxOps.test_functional_conv Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Added support for functional conv2d + relu, will add conv1d and conv3d in future PR Test Plan: python test/test_quantization.py TestQuantizeFxOps.test_functional_conv Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
vkuzo
approved these changes
Jan 26, 2021
| # Supported combinations are: | ||
| # quant_type | activation (compute_type) | weight | ||
| # static quint8 qint8 | ||
| # tuple (activation_dtype, weight_dtype, compute_dtype) |
Contributor
There was a problem hiding this comment.
is L224 related to L221:L223? It was a bit confusing to read, I might be missing something
Contributor
Author
There was a problem hiding this comment.
yeah this is a comment for supported_dtypes
| # quant_type | activation (compute_type) | weight | ||
| # static quint8 qint8 | ||
| # tuple (activation_dtype, weight_dtype, compute_dtype) | ||
| supported_dtypes = [ |
Contributor
There was a problem hiding this comment.
is this related to the comments above?
Comment on lines
+232
to
+237
| if dtypes not in supported_dtypes: | ||
| warnings.warn( | ||
| "dtype combination: {} is not " | ||
| "supported by Conv " | ||
| "supported dtype combinations are: {}".format(dtypes, supported_dtypes)) | ||
| if self.relu_node: |
Contributor
There was a problem hiding this comment.
maybe we can add a comment that this is going to leave the unsupported dtype pattern unquantized? just for easier reading of the code
Summary: Added support for functional conv2d + relu, will add conv1d and conv3d in future PR Test Plan: python test/test_quantization.py TestQuantizeFxOps.test_functional_conv Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D26089964](https://our.internmc.facebook.com/intern/diff/D26089964) [ghstack-poisoned]
Contributor
|
This pull request has been merged in d3ec204. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#51079 Added support for functional conv2d + relu, will add conv1d and conv3d in future PR Test Plan: python test/test_quantization.py TestQuantizeFxOps.test_functional_conv Imported from OSS Reviewed By: vkuzo Differential Revision: D26089964 fbshipit-source-id: 8703de17de1469f7076651c386c83fb5922a56eb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Added support for functional conv2d + relu, will add conv1d and conv3d in future PR
Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_functional_conv
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D26089964