Skip to content

Turn on batched_grad testing for NewModuleTest#50740

Closed
zou3519 wants to merge 4 commits intogh/zou3519/342/basefrom
gh/zou3519/342/head
Closed

Turn on batched_grad testing for NewModuleTest#50740
zou3519 wants to merge 4 commits intogh/zou3519/342/basefrom
gh/zou3519/342/head

Conversation

@zou3519
Copy link
Copy Markdown
Contributor

@zou3519 zou3519 commented Jan 19, 2021

Stack from ghstack:

This PR adds a check_batched_grad=True option to
NewModuleTest-generated NN tests.

Test Plan:

  • run tests (pytest test/test_nn.py -v -rf)

Differential Revision: D25997679

This PR adds a `check_batched_grad=True` option to
NewModuleTest-generated NN tests.

Test Plan:
- run tests (`pytest test/test_nn.py -v -rf`)

[ghstack-poisoned]
This PR adds a `check_batched_grad=True` option to
NewModuleTest-generated NN tests.

Test Plan:
- run tests (`pytest test/test_nn.py -v -rf`)

[ghstack-poisoned]
Copy link
Copy Markdown
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This PR adds a `check_batched_grad=True` option to
NewModuleTest-generated NN tests.

Test Plan:
- run tests (`pytest test/test_nn.py -v -rf`)

[ghstack-poisoned]
This PR adds a `check_batched_grad=True` option to
NewModuleTest-generated NN tests.

Test Plan:
- run tests (`pytest test/test_nn.py -v -rf`)

[ghstack-poisoned]
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 21, 2021

Codecov Report

Merging #50740 (f5667cc) into gh/zou3519/342/base (258a9ba) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                 Coverage Diff                  @@
##           gh/zou3519/342/base   #50740   +/-   ##
====================================================
  Coverage                81.01%   81.01%           
====================================================
  Files                     1916     1916           
  Lines                   209287   209288    +1     
====================================================
+ Hits                    169561   169563    +2     
+ Misses                   39726    39725    -1     

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@zou3519 merged this pull request in 63838b9.

@facebook-github-bot facebook-github-bot deleted the gh/zou3519/342/head branch January 26, 2021 15:21
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Pull Request resolved: pytorch#50740

This PR adds a `check_batched_grad=True` option to
NewModuleTest-generated NN tests.

Test Plan: - run tests (`pytest test/test_nn.py -v -rf`)

Reviewed By: ejguan

Differential Revision: D25997679

Pulled By: zou3519

fbshipit-source-id: b75e73d7e86fd3af9bad6efed7127b36551587b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants