Skip to content

Turn on batched grad testing for CriterionTest#50744

Closed
zou3519 wants to merge 4 commits intogh/zou3519/343/basefrom
gh/zou3519/343/head
Closed

Turn on batched grad testing for CriterionTest#50744
zou3519 wants to merge 4 commits intogh/zou3519/343/basefrom
gh/zou3519/343/head

Conversation

@zou3519
Copy link
Copy Markdown
Contributor

@zou3519 zou3519 commented Jan 19, 2021

Stack from ghstack:

This PR adds a check_batched_grad=True option to CriterionTest and
turns it on by default for all CriterionTest-generated tests

Test Plan:

  • run tests

Differential Revision: D25997676

This PR adds a `check_batched_grad=True` option to CriterionTest and
turns it on by default for all CriterionTest-generated tests

Test Plan:
- run tests

[ghstack-poisoned]
zou3519 added a commit that referenced this pull request Jan 19, 2021
This PR adds a `check_batched_grad=True` option to CriterionTest and
turns it on by default for all CriterionTest-generated tests

Test Plan:
- run tests

ghstack-source-id: e4383c1
Pull Request resolved: #50744
@zou3519 zou3519 requested review from albanD and ezyang January 20, 2021 15:11
Copy link
Copy Markdown
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This PR adds a `check_batched_grad=True` option to CriterionTest and
turns it on by default for all CriterionTest-generated tests

Test Plan:
- run tests

[ghstack-poisoned]
This PR adds a `check_batched_grad=True` option to CriterionTest and
turns it on by default for all CriterionTest-generated tests

Test Plan:
- run tests

[ghstack-poisoned]
zou3519 added a commit that referenced this pull request Jan 21, 2021
This PR adds a `check_batched_grad=True` option to CriterionTest and
turns it on by default for all CriterionTest-generated tests

Test Plan:
- run tests

ghstack-source-id: aea3bc6
Pull Request resolved: #50744
This PR adds a `check_batched_grad=True` option to CriterionTest and
turns it on by default for all CriterionTest-generated tests

Test Plan:
- run tests

Differential Revision: [D25997676](https://our.internmc.facebook.com/intern/diff/D25997676)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@zou3519 merged this pull request in 8331596.

@facebook-github-bot facebook-github-bot deleted the gh/zou3519/343/head branch January 30, 2021 15:21
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Pull Request resolved: pytorch#50744

This PR adds a `check_batched_grad=True` option to CriterionTest and
turns it on by default for all CriterionTest-generated tests

Test Plan: - run tests

Reviewed By: ejguan

Differential Revision: D25997676

Pulled By: zou3519

fbshipit-source-id: cc730731e6fae2bddc01bc93800fd0e3de28b32d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants