Skip to content

Turn on batched grad testing for non-autogenerated tests in test_nn.py#50739

Closed
zou3519 wants to merge 4 commits intogh/zou3519/341/basefrom
gh/zou3519/341/head
Closed

Turn on batched grad testing for non-autogenerated tests in test_nn.py#50739
zou3519 wants to merge 4 commits intogh/zou3519/341/basefrom
gh/zou3519/341/head

Conversation

@zou3519
Copy link
Copy Markdown
Contributor

@zou3519 zou3519 commented Jan 19, 2021

Stack from ghstack:

This does not turn on batched grad testing for autogenerated NewModuleTest
tests and CriterionTest tests. Those are coming later.

Test Plan:

  • run tests

Differential Revision: D25997677

This does not turn on batched grad testing for autogenerated NewModuleTest
tests and CriterionTest tests. Those are coming later.

Test Plan:
- run tests

[ghstack-poisoned]
…n test_nn.py"

This does not turn on batched grad testing for autogenerated NewModuleTest
tests and CriterionTest tests. Those are coming later.

Test Plan:
- run tests

[ghstack-poisoned]
Copy link
Copy Markdown
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…n test_nn.py"

This does not turn on batched grad testing for autogenerated NewModuleTest
tests and CriterionTest tests. Those are coming later.

Test Plan:
- run tests

[ghstack-poisoned]
…n test_nn.py"

This does not turn on batched grad testing for autogenerated NewModuleTest
tests and CriterionTest tests. Those are coming later.

Test Plan:
- run tests

[ghstack-poisoned]
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 21, 2021

Codecov Report

Merging #50739 (258a9ba) into gh/zou3519/341/base (2bbfeec) will increase coverage by 0.33%.
The diff coverage is 100.00%.

@@                   Coverage Diff                   @@
##           gh/zou3519/341/base   #50739      +/-   ##
=======================================================
+ Coverage                80.67%   81.01%   +0.33%     
=======================================================
  Files                     1916     1916              
  Lines                   209287   209287              
=======================================================
+ Hits                    168852   169561     +709     
+ Misses                   40435    39726     -709     

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@zou3519 merged this pull request in c7d348f.

@facebook-github-bot facebook-github-bot deleted the gh/zou3519/341/head branch January 26, 2021 15:21
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
pytorch#50739)

Summary:
Pull Request resolved: pytorch#50739

This does not turn on batched grad testing for autogenerated NewModuleTest
tests and CriterionTest tests. Those are coming later.

Test Plan: - run tests

Reviewed By: ejguan

Differential Revision: D25997677

Pulled By: zou3519

fbshipit-source-id: b4b2d68e0f99c3d573faf237e1e531d0b3fced40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants