[dist_optim] add distributed functional Adadelta optimizer#50623
Closed
wanchaol wants to merge 6 commits intogh/wanchaol/155/basefrom
Closed
[dist_optim] add distributed functional Adadelta optimizer#50623wanchaol wants to merge 6 commits intogh/wanchaol/155/basefrom
wanchaol wants to merge 6 commits intogh/wanchaol/155/basefrom
Conversation
Add TorchScript compatible Adadelta functional optimizer to distributed optimizer [ghstack-poisoned]
This was referenced Jan 15, 2021
This was referenced Jan 15, 2021
Add TorchScript compatible Adadelta functional optimizer to distributed optimizer [ghstack-poisoned]
This was referenced Jan 15, 2021
rohan-varma
reviewed
Jan 20, 2021
Contributor
rohan-varma
left a comment
There was a problem hiding this comment.
Looks like there is a potentially related CI failure, could you confirm?
Traceback (most recent call last):
File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 422, in wrapper
fn(*args, **kwargs)
File "test_optim.py", line 380, in test_multi_tensor_optimizers
self.assertEqual(p1, p2)
File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 1179, in assertEqual
super().assertTrue(result, msg=self._get_assert_msg(msg, debug_msg=debug_msg))
AssertionError: False is not true : Tensors failed to compare as equal!With rtol=1e-07 and atol=1e-07, found 6 element(s) (out of 6) whose difference(s) exceeded the margin of error (including 0 nan comparisons). The greatest difference was 0.14733898893893732 (0.020583703180005117 vs. 0.16792269211894245), which occurred at index (2, 1).
Add TorchScript compatible Adadelta functional optimizer to distributed optimizer Differential Revision: [D25932772](https://our.internmc.facebook.com/intern/diff/D25932772) [ghstack-poisoned]
Add TorchScript compatible Adadelta functional optimizer to distributed optimizer Differential Revision: [D25932772](https://our.internmc.facebook.com/intern/diff/D25932772) [ghstack-poisoned]
Add TorchScript compatible Adadelta functional optimizer to distributed optimizer Differential Revision: [D25932772](https://our.internmc.facebook.com/intern/diff/D25932772) [ghstack-poisoned]
rohan-varma
approved these changes
Jan 21, 2021
Contributor
rohan-varma
left a comment
There was a problem hiding this comment.
CI looks good now, LGTM
Add TorchScript compatible Adadelta functional optimizer to distributed optimizer Differential Revision: [D25932772](https://our.internmc.facebook.com/intern/diff/D25932772) [ghstack-poisoned]
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…0623) Summary: Pull Request resolved: pytorch#50623 Add TorchScript compatible Adadelta functional optimizer to distributed optimizer Test Plan: Imported from OSS Reviewed By: rohan-varma Differential Revision: D25932772 Pulled By: wanchaol fbshipit-source-id: d59b04e5f0b6bab7e0d1c5f68e66249a65958e0b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Add TorchScript compatible Adadelta functional optimizer to distributed optimizer
Differential Revision: D25932772