[dist_optim] add distributed functional sgd optimizer#50618
Closed
wanchaol wants to merge 7 commits intogh/wanchaol/152/basefrom
Closed
[dist_optim] add distributed functional sgd optimizer#50618wanchaol wants to merge 7 commits intogh/wanchaol/152/basefrom
wanchaol wants to merge 7 commits intogh/wanchaol/152/basefrom
Conversation
[ghstack-poisoned]
This was referenced Jan 15, 2021
[ghstack-poisoned]
[ghstack-poisoned]
This was referenced Jan 15, 2021
rohan-varma
approved these changes
Jan 19, 2021
Contributor
rohan-varma
left a comment
There was a problem hiding this comment.
Looks good as it matches the implementation in #45597
| def test_dist_optim_functional(self): | ||
| self._test_dist_optim_base(optim.Adagrad, lr=0.05) | ||
| self._test_dist_optim_base(optim.Adam, lr=1e-2, amsgrad=True) | ||
| self._test_dist_optim_base(optim.SGD, lr=0.05) |
Contributor
There was a problem hiding this comment.
Is this test now duplicated with the one on line 203 of this file?
Collaborator
Author
There was a problem hiding this comment.
Yes you are right, right now we are defaulting to use the torchscripted version of optimizer, let me merge these two.
Differential Revision: [D25932778](https://our.internmc.facebook.com/intern/diff/D25932778) [ghstack-poisoned]
Differential Revision: [D25932778](https://our.internmc.facebook.com/intern/diff/D25932778) [ghstack-poisoned]
Differential Revision: [D25932778](https://our.internmc.facebook.com/intern/diff/D25932778) [ghstack-poisoned]
Differential Revision: [D25932778](https://our.internmc.facebook.com/intern/diff/D25932778) [ghstack-poisoned]
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#50618 Test Plan: Imported from OSS Reviewed By: rohan-varma Differential Revision: D25932778 Pulled By: wanchaol fbshipit-source-id: 8df3567b477bc5ba3556b8c5294cd3da5db963ad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D25932778