[dist_optim] add warning to distributed optimizer#50630
Closed
wanchaol wants to merge 8 commits intogh/wanchaol/157/basefrom
Closed
[dist_optim] add warning to distributed optimizer#50630wanchaol wants to merge 8 commits intogh/wanchaol/157/basefrom
wanchaol wants to merge 8 commits intogh/wanchaol/157/basefrom
Conversation
Add a warning log to distributed optimizer, to warn user the optimizer is created without TorchScript support. [ghstack-poisoned]
This was referenced Jan 15, 2021
This was referenced Jan 15, 2021
Add a warning log to distributed optimizer, to warn user the optimizer is created without TorchScript support. [ghstack-poisoned]
rohan-varma
reviewed
Jan 15, 2021
| "slow computation time in multithreading environment (i.e. Distributed Model " | ||
| "Parallel training on CPU) due to the python Global Interpreter Lock (GIL). " | ||
| "Please file an issue if you need this optimizer in TorchScript. ", | ||
| str(optimizer_class) |
rohan-varma
reviewed
Jan 15, 2021
| optimizer_new_func = _new_script_local_optimizer | ||
| else: | ||
| logger.warn( | ||
| "Creating the optimizer %s without TorchScript support, this might results in " |
Contributor
There was a problem hiding this comment.
"this might results" -> "this might result"
rohan-varma
approved these changes
Jan 15, 2021
Add a warning log to distributed optimizer, to warn user the optimizer is created without TorchScript support. Differential Revision: [D25932777](https://our.internmc.facebook.com/intern/diff/D25932777) [ghstack-poisoned]
Add a warning log to distributed optimizer, to warn user the optimizer is created without TorchScript support. Differential Revision: [D25932777](https://our.internmc.facebook.com/intern/diff/D25932777) [ghstack-poisoned]
Add a warning log to distributed optimizer, to warn user the optimizer is created without TorchScript support. Differential Revision: [D25932777](https://our.internmc.facebook.com/intern/diff/D25932777) [ghstack-poisoned]
Add a warning log to distributed optimizer, to warn user the optimizer is created without TorchScript support. Differential Revision: [D25932777](https://our.internmc.facebook.com/intern/diff/D25932777) [ghstack-poisoned]
Add a warning log to distributed optimizer, to warn user the optimizer is created without TorchScript support. Differential Revision: [D25932777](https://our.internmc.facebook.com/intern/diff/D25932777) [ghstack-poisoned]
Add a warning log to distributed optimizer, to warn user the optimizer is created without TorchScript support. Differential Revision: [D25932777](https://our.internmc.facebook.com/intern/diff/D25932777) [ghstack-poisoned]
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#50630 Add a warning log to distributed optimizer, to warn user the optimizer is created without TorchScript support. Test Plan: Imported from OSS Reviewed By: rohan-varma Differential Revision: D25932777 Pulled By: wanchaol fbshipit-source-id: 8db3b98bdd27fc04c5a3b8d910b028c0c37f138d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Add a warning log to distributed optimizer, to warn user the optimizer
is created without TorchScript support.
Differential Revision: D25932777