Delete NativeFunctions.h include from Functions.h#48687
Closed
ezyang wants to merge 2 commits intogh/ezyang/878/basefrom
Closed
Delete NativeFunctions.h include from Functions.h#48687ezyang wants to merge 2 commits intogh/ezyang/878/basefrom
ezyang wants to merge 2 commits intogh/ezyang/878/basefrom
Conversation
Only one header needed to be updated to now include NativeFunctions.h Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
This was referenced Dec 2, 2020
bhosmer
approved these changes
Dec 2, 2020
💊 CI failures summary and remediationsAs of commit c409ae7 (more details on the Dr. CI page):
2 failures not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 4 times. |
Only one header needed to be updated to now include NativeFunctions.h Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
Contributor
shaibagon
pushed a commit
to shaibagon/pytorch
that referenced
this pull request
Dec 3, 2020
Summary: Pull Request resolved: pytorch#48687 Only one header needed to be updated to now include NativeFunctions.h Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: bhosmer Differential Revision: D25261845 Pulled By: ezyang fbshipit-source-id: de778b5e014c812c52a307841827193ce823afcc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Only one header needed to be updated to now include NativeFunctions.h
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D25261845