Move var and std overloads to Functions.cpp and remove native:: reference#48683
Closed
ezyang wants to merge 2 commits intogh/ezyang/876/basefrom
Closed
Move var and std overloads to Functions.cpp and remove native:: reference#48683ezyang wants to merge 2 commits intogh/ezyang/876/basefrom
ezyang wants to merge 2 commits intogh/ezyang/876/basefrom
Conversation
Overall goal: delete NativeFunctions.h from Functions.h header. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
This was referenced Dec 2, 2020
Overall goal: delete NativeFunctions.h from Functions.h header. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
bhosmer
approved these changes
Dec 2, 2020
Codecov Report
@@ Coverage Diff @@
## gh/ezyang/876/base #48683 +/- ##
======================================================
- Coverage 80.39% 80.39% -0.01%
======================================================
Files 1830 1830
Lines 192491 192491
======================================================
- Hits 154755 154750 -5
- Misses 37736 37741 +5 |
Contributor
shaibagon
pushed a commit
to shaibagon/pytorch
that referenced
this pull request
Dec 3, 2020
…ence (pytorch#48683) Summary: Pull Request resolved: pytorch#48683 I want to delete NativeFunctions.h from Functions.h header. To do this I must remove all references to native:: However; I also must avoid trampling over iseeyuan's work of making ATen compilable without reference to ATen_cpu. In this particular case, I fix the Functions.h problem by moving it to a cpp file, and removing the native:: short-circuit (ostensibly there for performances). This also fixes a hypothetical correctness bug where these would not dispatch properly if the underlying functions no longer uniformly used a single native:: implementation. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: bhosmer Differential Revision: D25261843 Pulled By: ezyang fbshipit-source-id: 05ca6555fbf1062f9b22d868c8cb88fdf8e4c24b
Contributor
Author
|
cc @peterbell10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
I want to delete NativeFunctions.h from Functions.h header. To do this I must remove all references to native:: However; I also must avoid trampling over iseeyuan's work of making ATen compilable without reference to ATen_cpu. In this particular case, I fix the Functions.h problem by moving it to a cpp file, and removing the native:: short-circuit (ostensibly there for performances). This also fixes a hypothetical correctness bug where these would not dispatch properly if the underlying functions no longer uniformly used a single native:: implementation.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D25261843