Refactor argument fields in FunctionSchema to Arguments#48182
Closed
ezyang wants to merge 4 commits intogh/ezyang/868/basefrom
Closed
Refactor argument fields in FunctionSchema to Arguments#48182ezyang wants to merge 4 commits intogh/ezyang/868/basefrom
ezyang wants to merge 4 commits intogh/ezyang/868/basefrom
Conversation
I'm planning to add a bunch more argument fields following #45890 (comment) and it will be a lot more convenient if the arguments get to live in their own dedicated struct. Type checker will tell you if I've done it wrong. No change to output. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
This was referenced Nov 18, 2020
ezyang
added a commit
that referenced
this pull request
Nov 18, 2020
I'm planning to add a bunch more argument fields following #45890 (comment) and it will be a lot more convenient if the arguments get to live in their own dedicated struct. Type checker will tell you if I've done it wrong. No change to output. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 98f206d Pull Request resolved: #48182
💊 CI failures summary and remediationsAs of commit 8aa9c04 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 15 times. |
This was referenced Nov 18, 2020
I'm planning to add a bunch more argument fields following #45890 (comment) and it will be a lot more convenient if the arguments get to live in their own dedicated struct. Type checker will tell you if I've done it wrong. No change to output. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D25057897](https://our.internmc.facebook.com/intern/diff/D25057897) [ghstack-poisoned]
ljk53
approved these changes
Nov 30, 2020
bhosmer
approved these changes
Nov 30, 2020
I'm planning to add a bunch more argument fields following #45890 (comment) and it will be a lot more convenient if the arguments get to live in their own dedicated struct. Type checker will tell you if I've done it wrong. No change to output. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D25057897](https://our.internmc.facebook.com/intern/diff/D25057897) [ghstack-poisoned]
ezyang
added a commit
to ezyang/pytorch
that referenced
this pull request
Dec 1, 2020
I'm planning to add a bunch more argument fields following pytorch#45890 (comment) and it will be a lot more convenient if the arguments get to live in their own dedicated struct. Type checker will tell you if I've done it wrong. No change to output. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 05be730 Pull Request resolved: pytorch#48182
ezyang
added a commit
to ezyang/pytorch
that referenced
this pull request
Dec 2, 2020
I'm planning to add a bunch more argument fields following pytorch#45890 (comment) and it will be a lot more convenient if the arguments get to live in their own dedicated struct. Type checker will tell you if I've done it wrong. No change to output. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 05be730 Pull Request resolved: pytorch#48182
I'm planning to add a bunch more argument fields following #45890 (comment) and it will be a lot more convenient if the arguments get to live in their own dedicated struct. Type checker will tell you if I've done it wrong. No change to output. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D25057897](https://our.internmc.facebook.com/intern/diff/D25057897) [ghstack-poisoned]
This was referenced Dec 2, 2020
ezyang
added a commit
to ezyang/pytorch
that referenced
this pull request
Dec 2, 2020
I'm planning to add a bunch more argument fields following pytorch#45890 (comment) and it will be a lot more convenient if the arguments get to live in their own dedicated struct. Type checker will tell you if I've done it wrong. No change to output. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: d7c85a9 Pull Request resolved: pytorch#48182
Contributor
shaibagon
pushed a commit
to shaibagon/pytorch
that referenced
this pull request
Dec 3, 2020
Summary: Pull Request resolved: pytorch#48182 I'm planning to add a bunch more argument fields following pytorch#45890 (comment) and it will be a lot more convenient if the arguments get to live in their own dedicated struct. Type checker will tell you if I've done it wrong. No change to output. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: ljk53 Differential Revision: D25057897 Pulled By: ezyang fbshipit-source-id: dd377181dad6ab0c894d19d83408b7812775a691
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
I'm planning to add a bunch more argument fields following
#45890 (comment) and
it will be a lot more convenient if the arguments get to live
in their own dedicated struct. Type checker will tell you if
I've done it wrong. No change to output.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D25057897