Skip to content

Delete Vulkan from code generator.#46938

Closed
ezyang wants to merge 4 commits intogh/ezyang/855/basefrom
gh/ezyang/855/head
Closed

Delete Vulkan from code generator.#46938
ezyang wants to merge 4 commits intogh/ezyang/855/basefrom
gh/ezyang/855/head

Conversation

@ezyang
Copy link
Copy Markdown
Contributor

@ezyang ezyang commented Oct 27, 2020 •
edited
Loading

Stack from ghstack:

It turns out that after #42194
landed we no longer actually generate any registrations into this
file. That means it's completely unnecessary.

Signed-off-by: Edward Z. Yang ezyang@fb.com

Differential Revision: D24573518

@ezyang
Delete Vulkan from code generator.
7987588 
It turns out that after #42194
landed we no longer actually generate any registrations into this
file.  That means it's completely unnecessary.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Oct 27, 2020
@ezyang
Delete Vulkan from code generator.
227b919 
It turns out that after #42194
landed we no longer actually generate any registrations into this
file.  That means it's completely unnecessary.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

ghstack-source-id: f224373
Pull Request resolved: #46938
@ezyang ezyang mentioned this pull request Oct 27, 2020
Closed
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Oct 27, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 501ceda (more details on the Dr. CI page):

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_bazel_build (1/1)

Step: "Bazel Build" (full log | diagnosis details | 🔁 rerun)

Oct 28 16:11:22 sccache: error: couldn't connect to server 
Oct 28 16:11:22 +++ eval 'extract_trap_cmd ' 
Oct 28 16:11:22 ++++ extract_trap_cmd 
Oct 28 16:11:22 ++++ printf '%s\n' '' 
Oct 28 16:11:22 +++ printf '%s\n' cleanup 
Oct 28 16:11:22 ++ trap -- ' 
Oct 28 16:11:22 cleanup' EXIT 
Oct 28 16:11:22 ++ [[ pytorch-linux-xenial-py3.6-gcc7-bazel-build != *pytorch-win-* ]] 
Oct 28 16:11:22 ++ which sccache 
Oct 28 16:11:22 ++ sccache --stop-server 
Oct 28 16:11:22 Stopping sccache server... 
Oct 28 16:11:22 sccache: error: couldn't connect to server 
Oct 28 16:11:22 sccache: caused by: Connection refused (os error 111) 
Oct 28 16:11:22 ++ true 
Oct 28 16:11:22 ++ rm /var/lib/jenkins/sccache_error.log 
Oct 28 16:11:23 rm: cannot remove '/var/lib/jenkins/sccache_error.log': No such file or directory 
Oct 28 16:11:23 ++ true 
Oct 28 16:11:23 ++ [[ pytorch-linux-xenial-py3.6-gcc7-bazel-build == *rocm* ]] 
Oct 28 16:11:23 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log 
Oct 28 16:11:23 ++ SCCACHE_IDLE_TIMEOUT=1200 
Oct 28 16:11:23 ++ RUST_LOG=sccache::server=error 
Oct 28 16:11:23 ++ sccache --start-server

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

If your commit is older than viable/strict:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 12 times.

@ezyang
Update on "Delete Vulkan from code generator."
3f7d300 
It turns out that after #42194
landed we no longer actually generate any registrations into this
file.  That means it's completely unnecessary.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D24573518](https://our.internmc.facebook.com/intern/diff/D24573518)

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Oct 27, 2020
@ezyang
Delete Vulkan from code generator.
f72d515 
It turns out that after #42194
landed we no longer actually generate any registrations into this
file.  That means it's completely unnecessary.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

ghstack-source-id: 773487e
Pull Request resolved: #46938
@ezyang
Update on "Delete Vulkan from code generator."
cef9050 
It turns out that after #42194
landed we no longer actually generate any registrations into this
file.  That means it's completely unnecessary.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D24573518](https://our.internmc.facebook.com/intern/diff/D24573518)

[ghstack-poisoned]
This was referenced Oct 28, 2020
Closed
Closed
@ezyang
Update on "Delete Vulkan from code generator."
501ceda 
It turns out that after #42194
landed we no longer actually generate any registrations into this
file.  That means it's completely unnecessary.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D24573518](https://our.internmc.facebook.com/intern/diff/D24573518)

[ghstack-poisoned]
This was referenced Oct 28, 2020
Closed
Closed
Closed
Closed
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Oct 30, 2020

@ezyang merged this pull request in dc6f723.

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/855/head branch November 2, 2020 15:17
@MambaWong MambaWong mentioned this pull request Apr 20, 2022
Closed
pytorchmergebot pushed a commit that referenced this pull request Apr 25, 2022
@MambaWong @pytorchmergebot
delete ${GEN_VULKAN_FLAGS}
bc9bba9 
'--vulkan' no longer exists in 'tools/codegen/gen.py', was deleted in #46938.

Pull Request resolved: #76080
Approved by: https://github.com/albanD
facebook-github-bot pushed a commit that referenced this pull request Apr 26, 2022
@MambaWong @facebook-github-bot
delete ${GEN_VULKAN_FLAGS} (#76080)
0e60b04 
Summary:
'--vulkan' no longer exists in 'tools/codegen/gen.py', was deleted in #46938.

Pull Request resolved: #76080
Approved by: https://github.com/albanD

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bc9bba9b439f50d74d1fd81882dc62c98ab67d85

Reviewed By: osalpekar

Differential Revision: D35938179

fbshipit-source-id: adea7c1d4d23c5b0f9aa30bb3a99606cc566ef7c
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@ezyang @facebook-github-bot
Delete Vulkan from code generator. (pytorch#46938)
f41ef61 
Summary:
Pull Request resolved: pytorch#46938

It turns out that after pytorch#42194
landed we no longer actually generate any registrations into this
file.  That means it's completely unnecessary.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Test Plan: Imported from OSS

Reviewed By: IvanKobzarev

Differential Revision: D24573518

Pulled By: ezyang

fbshipit-source-id: b41ada9e394b780f037f5977596a36b896b5648c
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@MambaWong @pytorchmergebot
delete ${GEN_VULKAN_FLAGS}
bc97e78 
'--vulkan' no longer exists in 'tools/codegen/gen.py', was deleted in pytorch#46938.

Pull Request resolved: pytorch#76080
Approved by: https://github.com/albanD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IvanKobzarev IvanKobzarev IvanKobzarev approved these changes

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ezyang @facebook-github-bot @IvanKobzarev