Skip to content

Some miscellaneous cleanup in codegen#46940

Closed
ezyang wants to merge 3 commits intogh/ezyang/856/basefrom
gh/ezyang/856/head
Closed

Some miscellaneous cleanup in codegen#46940
ezyang wants to merge 3 commits intogh/ezyang/856/basefrom
gh/ezyang/856/head

Conversation

@ezyang
Copy link
Copy Markdown
Contributor

@ezyang ezyang commented Oct 27, 2020 •
edited
Loading

Stack from ghstack:

  • Remove inaccurate @generated comments
  • Delete some dead code
  • Delete some unused headers
  • Delete unnecessary SparseTypeDerived.cpp template

Signed-off-by: Edward Z. Yang ezyang@fb.com

Differential Revision: D24573971

@ezyang
Some miscellaneous cleanup in codegen
b4f8f45 
- Remove inaccurate @generated comments
- Delete some dead code
- Delete some unused headers
- Delete unnecessary SparseTypeDerived.cpp template

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Oct 27, 2020
Closed
ezyang added a commit that referenced this pull request Oct 27, 2020
@ezyang
Some miscellaneous cleanup in codegen
f45f823 
- Remove inaccurate @generated comments
- Delete some dead code
- Delete some unused headers
- Delete unnecessary SparseTypeDerived.cpp template

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

ghstack-source-id: aac53d1
Pull Request resolved: #46940
@ezyang ezyang requested a review from bdhirsh October 27, 2020 20:02
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Oct 27, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 75d4d6f (more details on the Dr. CI page):

  • 2/3 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)
  • 1/3 broken upstream at merge base c886c7f on Oct 28 from 6:48am to 10:32am PDT (11 commits; 46b252b - 61ee024)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_bionic_py3_8_gcc9_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Oct 28 16:11:58 sccache: error: couldn't connect to server 
Oct 28 16:11:58 +++ eval 'extract_trap_cmd ' 
Oct 28 16:11:58 ++++ extract_trap_cmd 
Oct 28 16:11:58 ++++ printf '%s\n' '' 
Oct 28 16:11:58 +++ printf '%s\n' cleanup 
Oct 28 16:11:58 ++ trap -- ' 
Oct 28 16:11:58 cleanup' EXIT 
Oct 28 16:11:58 ++ [[ pytorch-linux-bionic-py3.8-gcc9-build != *pytorch-win-* ]] 
Oct 28 16:11:58 ++ which sccache 
Oct 28 16:11:58 ++ sccache --stop-server 
Oct 28 16:11:58 Stopping sccache server... 
Oct 28 16:11:58 sccache: error: couldn't connect to server 
Oct 28 16:11:58 sccache: caused by: Connection refused (os error 111) 
Oct 28 16:11:58 ++ true 
Oct 28 16:11:58 ++ rm /var/lib/jenkins/sccache_error.log 
Oct 28 16:11:58 rm: cannot remove '/var/lib/jenkins/sccache_error.log': No such file or directory 
Oct 28 16:11:58 ++ true 
Oct 28 16:11:58 ++ [[ pytorch-linux-bionic-py3.8-gcc9-build == *rocm* ]] 
Oct 28 16:11:58 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log 
Oct 28 16:11:58 ++ SCCACHE_IDLE_TIMEOUT=1200 
Oct 28 16:11:58 ++ RUST_LOG=sccache::server=error 
Oct 28 16:11:58 ++ sccache --start-server

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

If your commit is older than viable/strict:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 13 times.

bdhirsh
bdhirsh reviewed Oct 27, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bdhirsh bdhirsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some build failures in CUDAType.h

@ezyang
Update on "Some miscellaneous cleanup in codegen"
c18a51b 
- Remove inaccurate @generated comments
- Delete some dead code
- Delete some unused headers
- Delete unnecessary SparseTypeDerived.cpp template

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D24573971](https://our.internmc.facebook.com/intern/diff/D24573971)

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Oct 28, 2020
@ezyang
Some miscellaneous cleanup in codegen
48f4842 
- Remove inaccurate @generated comments
- Delete some dead code
- Delete some unused headers
- Delete unnecessary SparseTypeDerived.cpp template

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

ghstack-source-id: 347caa5
Pull Request resolved: #46940
This was referenced Oct 28, 2020
Closed
Closed
@ezyang
Update on "Some miscellaneous cleanup in codegen"
75d4d6f 
- Remove inaccurate @generated comments
- Delete some dead code
- Delete some unused headers
- Delete unnecessary SparseTypeDerived.cpp template

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D24573971](https://our.internmc.facebook.com/intern/diff/D24573971)

[ghstack-poisoned]
This was referenced Oct 28, 2020
Closed
Closed
Closed
Closed
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Oct 30, 2020

@ezyang merged this pull request in 87e86fa.

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/856/head branch November 2, 2020 15:17
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@ezyang @facebook-github-bot
Some miscellaneous cleanup in codegen (pytorch#46940)
e6729d2 
Summary:
Pull Request resolved: pytorch#46940

- Remove inaccurate generated comments
- Delete some dead code
- Delete some unused headers
- Delete unnecessary SparseTypeDerived.cpp template

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Test Plan: Imported from OSS

Reviewed By: albanD

Differential Revision: D24573971

Pulled By: ezyang

fbshipit-source-id: 3de05d9cd9bada4c73f01d6cfaf51f16ada66013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdhirsh bdhirsh bdhirsh approved these changes

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ezyang @facebook-github-bot @bdhirsh