Skip to content

delete ${GEN_VULKAN_FLAGS}#76080

Closed
MambaWong wants to merge 1 commit intopytorch:masterfrom
MambaWong:master
Closed

delete ${GEN_VULKAN_FLAGS}#76080
MambaWong wants to merge 1 commit intopytorch:masterfrom
MambaWong:master

Conversation

@MambaWong
Copy link
Copy Markdown
Contributor

@MambaWong MambaWong commented Apr 20, 2022

'--vulkan' no longer exists in 'tools/codegen/gen.py', was deleted in #46938.

@MambaWong
delete ${GEN_VULKAN_FLAGS}
f0dcf87 
'--vulkan' no longer exists in 'tools/codegen/gen.py', was deleted in #46938.
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Apr 20, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit f0dcf87 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

albanD
albanD approved these changes Apr 25, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@albanD
Copy link
Copy Markdown
Collaborator

albanD commented Apr 25, 2022

@pytorchbot merge this please

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 25, 2022

Hey @MambaWong.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Apr 26, 2022
@MambaWong @facebook-github-bot
delete ${GEN_VULKAN_FLAGS} (#76080)
0e60b04 
Summary:
'--vulkan' no longer exists in 'tools/codegen/gen.py', was deleted in #46938.

Pull Request resolved: #76080
Approved by: https://github.com/albanD

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bc9bba9b439f50d74d1fd81882dc62c98ab67d85

Reviewed By: osalpekar

Differential Revision: D35938179

fbshipit-source-id: adea7c1d4d23c5b0f9aa30bb3a99606cc566ef7c
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@MambaWong @pytorchmergebot
delete ${GEN_VULKAN_FLAGS}
bc97e78 
'--vulkan' no longer exists in 'tools/codegen/gen.py', was deleted in pytorch#46938.

Pull Request resolved: pytorch#76080
Approved by: https://github.com/albanD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

Assignees

No one assigned

Labels

cla signed open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MambaWong @facebook-github-bot @albanD @pytorchbot