For CriterionTests, have check_gradgrad actually only affect gradgrad checks.#44060
For CriterionTests, have check_gradgrad actually only affect gradgrad checks.#44060gchanan wants to merge 2 commits intogh/gchanan/318/basefrom
Conversation
… checks. Right now it skips grad checks as well. [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 175e0db (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 4 times. |
…ct gradgrad checks." Right now it skips grad checks as well. Differential Revision: [D23484018](https://our.internmc.facebook.com/intern/diff/D23484018) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/gchanan/318/base #44060 +/- ##
======================================================
Coverage ? 69.42%
======================================================
Files ? 381
Lines ? 47163
Branches ? 0
======================================================
Hits ? 32743
Misses ? 14420
Partials ? 0 Continue to review full report at Codecov.
|
|
|
||
| if not self.check_gradgrad: | ||
| return | ||
|
|
There was a problem hiding this comment.
nit: it might be better as
if self.check_gradgrad:
gradgradcheck(apply_fn, inputs)
that way if someone adds something to the end of this function in the future, they won't have to modify the (if not self.check_gradgrad line) (and they also won't accidentally not read it).
But this is pretty minor and I expect future code changes to get reviewed
Stack from ghstack:
Right now it skips grad checks as well.
Differential Revision: D23484018