Allow criterion backwards test on modules requiring extra args (i.e. CTCLoss).#44050
Closed
gchanan wants to merge 1 commit intogh/gchanan/315/basefrom
Closed
Allow criterion backwards test on modules requiring extra args (i.e. CTCLoss).#44050gchanan wants to merge 1 commit intogh/gchanan/315/basefrom
gchanan wants to merge 1 commit intogh/gchanan/315/basefrom
Conversation
…CTCLoss). We don't actually turn on the CTCLoss tests since they fail, but this allows you to toggle check_forward_only and for the code to actually run. [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 746f9dc (more details on the Dr. CI page):
1 failure confirmed as flaky and can be ignored:
ci.pytorch.org: 2 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 4 times. |
This was referenced Sep 2, 2020
Codecov Report
@@ Coverage Diff @@
## gh/gchanan/315/base #44050 +/- ##
=======================================================
- Coverage 69.42% 69.42% -0.01%
=======================================================
Files 381 381
Lines 47168 47168
=======================================================
- Hits 32747 32746 -1
- Misses 14421 14422 +1
Continue to review full report at Codecov.
|
zou3519
approved these changes
Sep 3, 2020
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We don't actually turn on the CTCLoss tests since they fail, but this allows you to toggle check_forward_only and for the code to actually run.
Differential Revision: D23481091