Merge CriterionTest into NewCriterionTest.#44055
Closed
gchanan wants to merge 2 commits intogh/gchanan/316/basefrom
Closed
Merge CriterionTest into NewCriterionTest.#44055gchanan wants to merge 2 commits intogh/gchanan/316/basefrom
gchanan wants to merge 2 commits intogh/gchanan/316/basefrom
Conversation
There is no functional change here. Another patch will rename NewCriterionTest to CriterionTest. [ghstack-poisoned]
This was referenced Sep 2, 2020
💊 CI failures summary and remediationsAs of commit a985ac1 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 7 times. |
There is no functional change here. Another patch will rename NewCriterionTest to CriterionTest. Differential Revision: [D23482572](https://our.internmc.facebook.com/intern/diff/D23482572) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/gchanan/316/base #44055 +/- ##
====================================================
Coverage 69.42% 69.42%
====================================================
Files 381 381
Lines 47168 47163 -5
====================================================
- Hits 32746 32743 -3
+ Misses 14422 14420 -2
Continue to review full report at Codecov.
|
zou3519
approved these changes
Sep 3, 2020
Contributor
zou3519
left a comment
There was a problem hiding this comment.
All of our criterion tests use NewCriterionTest; there are no tests that use CriterionTest, right?
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
There is no functional change here. Another patch will rename NewCriterionTest to CriterionTest.
Differential Revision: D23482572