[quant][graphmode] Support quantization for aten::append#39644
Closed
jerryzh168 wants to merge 6 commits intogh/jerryzh168/337/basefrom
Closed
[quant][graphmode] Support quantization for aten::append#39644jerryzh168 wants to merge 6 commits intogh/jerryzh168/337/basefrom
aten::append#39644jerryzh168 wants to merge 6 commits intogh/jerryzh168/337/basefrom
Conversation
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jun 8, 2020
💊 CI failures summary and remediationsAs of commit eed359a (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 22 times. |
| inputs.push_back(v); | ||
| } | ||
| return inputs; | ||
| } else if (n->kind() == Symbol::aten("append")) { |
Contributor
There was a problem hiding this comment.
How about adding a simple test to check for append?
raghuramank100
approved these changes
Jun 8, 2020
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21942112](https://our.internmc.facebook.com/intern/diff/D21942112) [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21942112](https://our.internmc.facebook.com/intern/diff/D21942112) [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21942112](https://our.internmc.facebook.com/intern/diff/D21942112) [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21942112](https://our.internmc.facebook.com/intern/diff/D21942112) [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21942112](https://our.internmc.facebook.com/intern/diff/D21942112) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 7994d6e. |
This was referenced Jun 10, 2020
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…9644) Summary: Pull Request resolved: pytorch#39644 Test Plan: Imported from OSS Differential Revision: D21942112 fbshipit-source-id: 8dc5871cbde9e9cc161a624c2b07e2e74bc0ff6d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
aten::append#39644 [quant][graphmode] Support quantization foraten::appendifin insert_observers #39615 [quant][graphmode] Fix a corner case in handlingifin insert_observersSummary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D21942112