Skip to content

[quant][graphmode] Support quantized::batch_norm2d_relu fusion for tracing#39645

Closed
jerryzh168 wants to merge 8 commits intogh/jerryzh168/338/basefrom
gh/jerryzh168/338/head
Closed

[quant][graphmode] Support quantized::batch_norm2d_relu fusion for tracing#39645
jerryzh168 wants to merge 8 commits intogh/jerryzh168/338/basefrom
gh/jerryzh168/338/head

Conversation

@jerryzh168
Copy link
Copy Markdown
Contributor

@jerryzh168 jerryzh168 commented Jun 8, 2020 •
edited
Loading

Stack from ghstack:

Summary:
This PR added quantization support for handling BatchNorm2d and ReLU(or F.relu) in both
scripting and tracing

Test Plan:
python test/test_quantization.py TestQuantizeScriptPTSQOps.test_qbatchnorm_relu
Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D21942111

@jerryzh168
[quant][graphmode] Support quantized::batch_norm2d_relu fusion for tr…
2461628 
…acing

Summary:
This PR added quantization support for handling BatchNorm2d and ReLU(or F.relu) in both
scripting and tracing

Test Plan:
python test/test_quantization.py TestQuantizeScriptPTSQOps.test_qbatchnorm_relu
Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168 jerryzh168 requested a review from apaszke as a code owner June 8, 2020 02:09
This was referenced Jun 8, 2020
Closed
Closed
Closed
Closed
jerryzh168 added a commit that referenced this pull request Jun 8, 2020
@jerryzh168
[quant][graphmode] Support quantized::batch_norm2d_relu fusion for tr…
2162caa 
…acing

Summary:
This PR added quantization support for handling BatchNorm2d and ReLU(or F.relu) in both
scripting and tracing

Test Plan:
python test/test_quantization.py TestQuantizeScriptPTSQOps.test_qbatchnorm_relu
Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 26bb3d5
Pull Request resolved: #39645
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 8, 2020
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Jun 8, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 0bab91e (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

Extra GitHub checks: 1 failed

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 32 times.

raghuramank100
raghuramank100 reviewed Jun 8, 2020
View reviewed changes
Comment thread test/quantization/test_quantize_script.py
.check_not("aten::relu") \
.check_not("aten::relu_") \
.run(model.graph)
for tracing in [True, False]:
Copy link
Copy Markdown
Contributor

@raghuramank100 raghuramank100 Jun 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test: test_qbatch_norm_relu can only run in FBGEMM as batch norm is not supported as an op in qnnpack, please add a check for qengine for this test.

Copy link
Copy Markdown
Contributor Author

@jerryzh168 jerryzh168 Jun 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll do skipIfNoFBGEMM

@jerryzh168
Update on "[quant][graphmode] Support quantized::batch_norm2d_relu fu…
c74f428 
…sion for tracing"

Summary:
This PR added quantization support for handling BatchNorm2d and ReLU(or F.relu) in both
scripting and tracing

Test Plan:
python test/test_quantization.py TestQuantizeScriptPTSQOps.test_qbatchnorm_relu
Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21942111](https://our.internmc.facebook.com/intern/diff/D21942111)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jun 8, 2020
@jerryzh168
[quant][graphmode] Support quantized::batch_norm2d_relu fusion for tr…
b1c645e 
…acing

Summary:
This PR added quantization support for handling BatchNorm2d and ReLU(or F.relu) in both
scripting and tracing

Test Plan:
python test/test_quantization.py TestQuantizeScriptPTSQOps.test_qbatchnorm_relu
Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: a5bd3d3
Pull Request resolved: #39645
@jerryzh168
Update on "[quant][graphmode] Support quantized::batch_norm2d_relu fu…
25b743e 
…sion for tracing"

Summary:
This PR added quantization support for handling BatchNorm2d and ReLU(or F.relu) in both
scripting and tracing

Test Plan:
python test/test_quantization.py TestQuantizeScriptPTSQOps.test_qbatchnorm_relu
Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21942111](https://our.internmc.facebook.com/intern/diff/D21942111)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jun 9, 2020
@jerryzh168
[quant][graphmode] Support quantized::batch_norm2d_relu fusion for tr…
23a259c 
…acing

Summary:
This PR added quantization support for handling BatchNorm2d and ReLU(or F.relu) in both
scripting and tracing

Test Plan:
python test/test_quantization.py TestQuantizeScriptPTSQOps.test_qbatchnorm_relu
Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 02cd9af
Pull Request resolved: #39645
@jerryzh168
Update on "[quant][graphmode] Support quantized::batch_norm2d_relu fu…
1eed76b 
…sion for tracing"

Summary:
This PR added quantization support for handling BatchNorm2d and ReLU(or F.relu) in both
scripting and tracing

Test Plan:
python test/test_quantization.py TestQuantizeScriptPTSQOps.test_qbatchnorm_relu
Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21942111](https://our.internmc.facebook.com/intern/diff/D21942111)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jun 10, 2020
@jerryzh168
[quant][graphmode] Support quantized::batch_norm2d_relu fusion for tr…
ecd0f15 
…acing

Summary:
This PR added quantization support for handling BatchNorm2d and ReLU(or F.relu) in both
scripting and tracing

Test Plan:
python test/test_quantization.py TestQuantizeScriptPTSQOps.test_qbatchnorm_relu
Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 60cac49
Pull Request resolved: #39645
@jerryzh168
Update on "[quant][graphmode] Support quantized::batch_norm2d_relu fu…
9ce53db 
…sion for tracing"

Summary:
This PR added quantization support for handling BatchNorm2d and ReLU(or F.relu) in both
scripting and tracing

Test Plan:
python test/test_quantization.py TestQuantizeScriptPTSQOps.test_qbatchnorm_relu
Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21942111](https://our.internmc.facebook.com/intern/diff/D21942111)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode] Support quantized::batch_norm2d_relu fu…
bd14abb 
…sion for tracing"

Summary:
This PR added quantization support for handling BatchNorm2d and ReLU(or F.relu) in both
scripting and tracing

Test Plan:
python test/test_quantization.py TestQuantizeScriptPTSQOps.test_qbatchnorm_relu
Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21942111](https://our.internmc.facebook.com/intern/diff/D21942111)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jun 10, 2020
@jerryzh168
[quant][graphmode] Support quantized::batch_norm2d_relu fusion for tr…
e13e6e9 
…acing

Summary:
This PR added quantization support for handling BatchNorm2d and ReLU(or F.relu) in both
scripting and tracing

Test Plan:
python test/test_quantization.py TestQuantizeScriptPTSQOps.test_qbatchnorm_relu
Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 8b4637b
Pull Request resolved: #39645
@jerryzh168
Update on "[quant][graphmode] Support quantized::batch_norm2d_relu fu…
8dd33d6 
…sion for tracing"

Summary:
This PR added quantization support for handling BatchNorm2d and ReLU(or F.relu) in both
scripting and tracing

Test Plan:
python test/test_quantization.py TestQuantizeScriptPTSQOps.test_qbatchnorm_relu
Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21942111](https://our.internmc.facebook.com/intern/diff/D21942111)

[ghstack-poisoned]
This was referenced Jun 10, 2020
Closed
Closed
@jerryzh168
Update on "[quant][graphmode] Support quantized::batch_norm2d_relu fu…
0bab91e 
…sion for tracing"

Summary:
This PR added quantization support for handling BatchNorm2d and ReLU(or F.relu) in both
scripting and tracing

Test Plan:
python test/test_quantization.py TestQuantizeScriptPTSQOps.test_qbatchnorm_relu
Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21942111](https://our.internmc.facebook.com/intern/diff/D21942111)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 11, 2020

This pull request has been merged in c3d4053.

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/338/head branch June 14, 2020 14:16
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@jerryzh168 @facebook-github-bot
[quant][graphmode] Support quantized::batch_norm2d_relu fusion for tr…
f72e894 
…acing (pytorch#39645)

Summary:
Pull Request resolved: pytorch#39645

This PR added quantization support for handling BatchNorm2d and ReLU(or F.relu) in both
scripting and tracing

Test Plan:
python test/test_quantization.py TestQuantizeScriptPTSQOps.test_qbatchnorm_relu

Imported from OSS

Differential Revision: D21942111

fbshipit-source-id: 680e16076a37b96d2485d5cbc39ce9a045c319c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apaszke apaszke Awaiting requested review from apaszke

1 more reviewer

@raghuramank100 raghuramank100 raghuramank100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jerryzh168 @facebook-github-bot @raghuramank100 @mruberry