[quant][graphmode] Fix a corner case in handling if in insert_observers#39615
Closed
jerryzh168 wants to merge 9 commits intogh/jerryzh168/336/basefrom
Closed
[quant][graphmode] Fix a corner case in handling if in insert_observers#39615jerryzh168 wants to merge 9 commits intogh/jerryzh168/336/basefrom
if in insert_observers#39615jerryzh168 wants to merge 9 commits intogh/jerryzh168/336/basefrom
Conversation
…vers Summary: corner case: https://github.com/pytorch/vision/blob/master/torchvision/models/densenet.py#L87 Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jun 6, 2020
…nsert_observers" Summary: corner case: https://github.com/pytorch/vision/blob/master/torchvision/models/densenet.py#L87 Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Jun 6, 2020
…vers Summary: corner case: https://github.com/pytorch/vision/blob/master/torchvision/models/densenet.py#L87 Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: aefa49d Pull Request resolved: #39615
💊 CI failures summary and remediationsAs of commit 9f9a5c1 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 38 times. |
…nsert_observers" Summary: corner case: https://github.com/pytorch/vision/blob/master/torchvision/models/densenet.py#L87 Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Jun 6, 2020
…vers Summary: corner case: https://github.com/pytorch/vision/blob/master/torchvision/models/densenet.py#L87 Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 91b0ce8 Pull Request resolved: #39615
…nsert_observers" Summary: corner case: https://github.com/pytorch/vision/blob/master/torchvision/models/densenet.py#L87 Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jun 8, 2020
| x = self.conv(x) | ||
| # x is already observed | ||
| if self.cond: | ||
| x = torch.flatten(x) |
Contributor
There was a problem hiding this comment.
If this operation where instead
if self.cond:
x = self.conv1(x)
return xyou would need to insert an observer after conv1. Is this tested?
Contributor
Author
There was a problem hiding this comment.
not yet, I can add the test
Contributor
Author
There was a problem hiding this comment.
this does not work since different branches of if not quantized the same way
Contributor
Author
There was a problem hiding this comment.
there is a conflict of rules at the moment if we want to support this, we can probably think about it later
Contributor
There was a problem hiding this comment.
Please file an issue to track this issue down the road.
Contributor
raghuramank100
left a comment
There was a problem hiding this comment.
A question on test coverage.
…nsert_observers" Summary: corner case: https://github.com/pytorch/vision/blob/master/torchvision/models/densenet.py#L87 Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21942110](https://our.internmc.facebook.com/intern/diff/D21942110) [ghstack-poisoned]
raghuramank100
approved these changes
Jun 9, 2020
…nsert_observers" Summary: corner case: https://github.com/pytorch/vision/blob/master/torchvision/models/densenet.py#L87 Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21942110](https://our.internmc.facebook.com/intern/diff/D21942110) [ghstack-poisoned]
…nsert_observers" Summary: corner case: https://github.com/pytorch/vision/blob/master/torchvision/models/densenet.py#L87 Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21942110](https://our.internmc.facebook.com/intern/diff/D21942110) [ghstack-poisoned]
…nsert_observers" Summary: corner case: https://github.com/pytorch/vision/blob/master/torchvision/models/densenet.py#L87 Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21942110](https://our.internmc.facebook.com/intern/diff/D21942110) [ghstack-poisoned]
…nsert_observers" Summary: corner case: https://github.com/pytorch/vision/blob/master/torchvision/models/densenet.py#L87 Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21942110](https://our.internmc.facebook.com/intern/diff/D21942110) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 2d589bc. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…vers (pytorch#39615) Summary: Pull Request resolved: pytorch#39615 corner case: https://github.com/pytorch/vision/blob/master/torchvision/models/densenet.py#L87 (Note: this ignores all push blocking failures!) Test Plan: Imported from OSS Differential Revision: D21942110 fbshipit-source-id: 9522032957575662d2648db2a41fa5410e8d1e3a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
aten::append#39644 [quant][graphmode] Support quantization foraten::appendifin insert_observers #39615 [quant][graphmode] Fix a corner case in handlingifin insert_observersSummary:
corner case: https://github.com/pytorch/vision/blob/master/torchvision/models/densenet.py#L87
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D21942110