Move (most) generated return statements for TH functions out of the switch.#38073
Closed
gchanan wants to merge 5 commits intogh/gchanan/276/basefrom
Closed
Move (most) generated return statements for TH functions out of the switch.#38073gchanan wants to merge 5 commits intogh/gchanan/276/basefrom
gchanan wants to merge 5 commits intogh/gchanan/276/basefrom
Conversation
…witch. Most of the generated return statements don't depend on the scalar type and it saves ~900 lines of generated code. [ghstack-poisoned]
This was referenced May 7, 2020
💊 CI failures summary and remediationsAs of commit ad80b46 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 19 times. |
Contributor
|
Generated code before and after? |
…ut of the switch." Most of the generated return statements don't depend on the scalar type and it saves ~900 lines of generated code. [ghstack-poisoned]
…ut of the switch." Most of the generated return statements don't depend on the scalar type and it saves ~900 lines of generated code. Differential Revision: [D21476010](https://our.internmc.facebook.com/intern/diff/D21476010) [ghstack-poisoned]
…ut of the switch." Most of the generated return statements don't depend on the scalar type and it saves ~900 lines of generated code. Differential Revision: [D21476010](https://our.internmc.facebook.com/intern/diff/D21476010) [ghstack-poisoned]
…ut of the switch." Most of the generated return statements don't depend on the scalar type and it saves ~900 lines of generated code. Differential Revision: [D21476010](https://our.internmc.facebook.com/intern/diff/D21476010) [ghstack-poisoned]
Contributor
Author
|
Here's a CPU diff: https://gist.github.com/gchanan/6364fa926d653b196ee081153428815a |
This was referenced May 11, 2020
ezyang
approved these changes
May 12, 2020
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…witch. (pytorch#38073) Summary: Pull Request resolved: pytorch#38073 Most of the generated return statements don't depend on the scalar type and it saves ~900 lines of generated code. Test Plan: Imported from OSS Differential Revision: D21476010 Pulled By: gchanan fbshipit-source-id: 3fcc4db466d697c90abafb9da6c3f3644621810b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Most of the generated return statements don't depend on the scalar type and it saves ~900 lines of generated code.
Differential Revision: D21476010