Skip to content

Split up BinaryAritmeticKernel.cu to speed up compilation time.#38263

Closed
gchanan wants to merge 5 commits intogh/gchanan/277/basefrom
gh/gchanan/277/head
Closed

Split up BinaryAritmeticKernel.cu to speed up compilation time.#38263
gchanan wants to merge 5 commits intogh/gchanan/277/basefrom
gh/gchanan/277/head

Conversation

@gchanan
Copy link
Copy Markdown
Contributor

@gchanan gchanan commented May 11, 2020

Stack from ghstack:

On my machine, compilation went from 4m8sec to the maximum of the files being compiled in 2m22sec.

Differential Revision: D21508985

On my machine, compilation went from 4m8sec to the maximum of the files being compiled in 2m22sec.

[ghstack-poisoned]
…time."

On my machine, compilation went from 4m8sec to the maximum of the files being compiled in 2m22sec.

Differential Revision: [D21508985](https://our.internmc.facebook.com/intern/diff/D21508985)

[ghstack-poisoned]
gchanan added a commit that referenced this pull request May 11, 2020
On my machine, compilation went from 4m8sec to the maximum of the files being compiled in 2m22sec.

ghstack-source-id: 5b1dc9c
Pull Request resolved: #38263
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 11, 2020

💊 CI failures summary and remediations

As of commit 58e301b (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 9 times.

Copy link
Copy Markdown
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped.

gchanan added 3 commits May 12, 2020 16:07
…time."

On my machine, compilation went from 4m8sec to the maximum of the files being compiled in 2m22sec.

Differential Revision: [D21508985](https://our.internmc.facebook.com/intern/diff/D21508985)

[ghstack-poisoned]
…time."

On my machine, compilation went from 4m8sec to the maximum of the files being compiled in 2m22sec.

Differential Revision: [D21508985](https://our.internmc.facebook.com/intern/diff/D21508985)

[ghstack-poisoned]
…time."

On my machine, compilation went from 4m8sec to the maximum of the files being compiled in 2m22sec.

Differential Revision: [D21508985](https://our.internmc.facebook.com/intern/diff/D21508985)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@gchanan merged this pull request in 899a075.

@facebook-github-bot facebook-github-bot deleted the gh/gchanan/277/head branch May 17, 2020 14:18
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
…rch#38263)

Summary:
Pull Request resolved: pytorch#38263

On my machine, compilation went from 4m8sec to the maximum of the files being compiled in 2m22sec.

Test Plan: Imported from OSS

Differential Revision: D21508985

Pulled By: gchanan

fbshipit-source-id: 2917cd5f30c6b31229053cada93c95e3a27ab29a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants