Kill resize-ing and zero-ing from codegen.#37958
Closed
gchanan wants to merge 6 commits intogh/gchanan/270/basefrom
Closed
Kill resize-ing and zero-ing from codegen.#37958gchanan wants to merge 6 commits intogh/gchanan/270/basefrom
gchanan wants to merge 6 commits intogh/gchanan/270/basefrom
Conversation
All codegen invocations have been removed at this point, so this has no effect. [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit f3f95bf (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 38 times. |
bhosmer
approved these changes
May 6, 2020
| if arg['name'] == 'grad_weight' and base['name'] != '_thnn_conv2d' and base['name'] != '_thnn_conv_depthwise2d': | ||
| arg['resize'] = 'weight' | ||
| arg['zero'] = True | ||
| if arg['name'] == 'grad_bias' and base['name'] != '_thnn_conv2d' and base['name'] != '_thnn_conv_depthwise2d': |
All codegen invocations have been removed at this point, so this has no effect. Differential Revision: [D21433215](https://our.internmc.facebook.com/intern/diff/D21433215) [ghstack-poisoned]
All codegen invocations have been removed at this point, so this has no effect. Differential Revision: [D21433215](https://our.internmc.facebook.com/intern/diff/D21433215) [ghstack-poisoned]
This was referenced May 7, 2020
All codegen invocations have been removed at this point, so this has no effect. Differential Revision: [D21433215](https://our.internmc.facebook.com/intern/diff/D21433215) [ghstack-poisoned]
This was referenced May 7, 2020
All codegen invocations have been removed at this point, so this has no effect. Differential Revision: [D21433215](https://our.internmc.facebook.com/intern/diff/D21433215) [ghstack-poisoned]
All codegen invocations have been removed at this point, so this has no effect. Differential Revision: [D21433215](https://our.internmc.facebook.com/intern/diff/D21433215) [ghstack-poisoned]
Contributor
This was referenced May 11, 2020
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#37958 All codegen invocations have been removed at this point, so this has no effect. Test Plan: Imported from OSS Reviewed By: mrshenli Differential Revision: D21433215 Pulled By: gchanan fbshipit-source-id: 1f58f3022fab6443e34f0201ae4b32b2a99725cf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
All codegen invocations have been removed at this point, so this has no effect.
Differential Revision: D21433215