Fix `.to` operator to preserve strides when `self` should be returned by VitalyFedyunin · Pull Request #31227 · pytorch/pytorch

VitalyFedyunin · 2019-12-13T01:29:04Z

Stack from ghstack:

Fix .to operator to preserve strides when self should be returned #31227 Fix .to operator to preserve strides when self should be returned
Revert "Switch default memory format of to (and similar) operators to Preserve" #31226 Revert "Switch default memory format of to (and similar) operators to Preserve"
[WIP] Fix cudnn channels_last descriptio problem #31139 [WIP] Fix cudnn channels_last descriptio problem
Add memory_format support to zeros, ones, full #31131 Add memory_format support to zeros, ones, full (still need tests)
Switch default memory format of clone operator to Preserve #30089 Switch default memory format of clone operator to Preserve
Switch default memory format of to (and similar) operators to Preserve #30088 Switch default memory format of to (and similar) operators to Preserve
Switch default memory format of _like operators to Preserve #30087 Switch default memory format of _like operators to Preserve

[ghstack-poisoned]

…uld be returned" [ghstack-poisoned]

ghstack-source-id: 2882cf9 Pull Request resolved: #31227

kostmo · 2019-12-13T03:12:42Z

CircleCI build failures summary

As of commit 79d00ad:

13/13 failures introduced in this PR

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

11 new failures recognized by patterns

The following build failures don't appear to be due to upstream breakage:

caffe2_onnx_py2_gcc5_ubuntu16_04_test (1/11)

Step: "Test" (details)

Dec 13 03:31:16 test/onnx/test_operators.py::TestOperators::test_empty_like PASSED       [  2%] 
Dec 13 03:31:16 test/onnx/test_operators.py::TestOperators::test_empty_like_opset7 PASSED [  2%] 
Dec 13 03:31:16 test/onnx/test_operators.py::TestOperators::test_equal PASSED            [  2%] 
Dec 13 03:31:16 test/onnx/test_operators.py::TestOperators::test_erf PASSED              [  2%] 
Dec 13 03:31:16 test/onnx/test_operators.py::TestOperators::test_exp PASSED              [  2%] 
Dec 13 03:31:16 test/onnx/test_operators.py::TestOperators::test_expand PASSED           [  2%] 
Dec 13 03:31:16 test/onnx/test_operators.py::TestOperators::test_flatten PASSED          [  2%] 
Dec 13 03:31:16 test/onnx/test_operators.py::TestOperators::test_flatten2D PASSED        [  2%] 
Dec 13 03:31:16 test/onnx/test_operators.py::TestOperators::test_fmod PASSED             [  2%] 
Dec 13 03:31:16 test/onnx/test_operators.py::TestOperators::test_frobenius_norm PASSED   [  2%] 
re dumped) pytest "${args[@]}" -k 'not (TestOperators and test_full_like) and not (TestOperators and test_zeros_like) and not (TestOperators and test_ones_like) and not (TestModels and test_vgg16) and not (TestModels and test_vgg16_bn) and not (TestModels and test_vgg19) and not (TestModels and test_vgg19_bn)' --ignore "$top_dir/test/onnx/test_pytorch_onnx_onnxruntime.py" --ignore "$top_dir/test/onnx/test_custom_ops.py" --ignore "$top_dir/test/onnx/test_models_onnxruntime.py" "${test_paths[@]}"

pytorch_linux_xenial_py2_7_9_test (2/11)

Step: "Test" (details)

Dec 13 03:36:27 Ran 1473 tests in 455.390s 
Dec 13 03:36:27  
Dec 13 03:36:27 FAILED (errors=2, skipped=699, expected failures=3) 
Dec 13 03:36:27  
Dec 13 03:36:27 Generating XML reports... 
Dec 13 03:36:27 Traceback (most recent call last): 
Dec 13 03:36:27   File "test/run_test.py", line 456, in <module> 
Dec 13 03:36:27     main() 
Dec 13 03:36:27   File "test/run_test.py", line 449, in main 
Dec 13 03:36:27     raise RuntimeError(message) 
Dec 13 03:36:27 RuntimeError: test_nn failed! 
Dec 13 03:36:27 + cleanup 
Dec 13 03:36:27 + retcode=1 
Dec 13 03:36:27 + set +x 
Dec 13 03:36:27 =================== sccache compilation log =================== 
Dec 13 03:36:27 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Dec 13 03:36:27 Compile requests                 10 
Dec 13 03:36:27 Compile requests executed         8 
Dec 13 03:36:27 Cache hits                        2 
Dec 13 03:36:27 Cache misses                      6 
Dec 13 03:36:27 Cache timeouts                    0

pytorch_xla_linux_xenial_py3_6_clang7_test (3/11)

Step: "Test" (details)

Dec 13 04:11:22 +++ eval 'extract_trap_cmd ' 
Dec 13 04:11:22 ++++ extract_trap_cmd 
Dec 13 04:11:22 ++++ printf '%s\n' '' 
Dec 13 04:11:22 +++ printf '%s\n' cleanup 
Dec 13 04:11:22 ++ trap -- ' 
Dec 13 04:11:22 cleanup' EXIT 
Dec 13 04:11:22 ++ which sccache 
Dec 13 04:11:22 ++ sccache --stop-server 
Dec 13 04:11:22 Stopping sccache server... 
Dec 13 04:11:22 error: couldn't connect to server 
Dec 13 04:11:22 caused by: Connection refused (os error 111) 
Dec 13 04:11:22 ++ true 
Dec 13 04:11:22 ++ rm /var/lib/jenkins/sccache_error.log 
Dec 13 04:11:22 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log 
Dec 13 04:11:22 ++ SCCACHE_IDLE_TIMEOUT=1200 
Dec 13 04:11:22 ++ RUST_LOG=sccache::server=error 
Dec 13 04:11:22 ++ sccache --start-server 
Dec 13 04:11:22 Starting sccache server... 
Dec 13 04:11:23 ++ sccache --zero-stats 
Dec 13 04:11:23 Compile requests                 0 
Dec 13 04:11:23 Compile requests executed        0

pytorch_linux_xenial_py3_clang5_asan_test (4/11)

Step: "Test" (details)

Dec 13 04:24:49 Ran 1473 tests in 1867.463s 
Dec 13 04:24:49  
Dec 13 04:24:49 FAILED (errors=2, skipped=681, expected failures=2) 
Dec 13 04:24:49  
Dec 13 04:24:49 Generating XML reports... 
Dec 13 04:24:50 Traceback (most recent call last): 
Dec 13 04:24:50   File "test/run_test.py", line 456, in <module> 
Dec 13 04:24:50     main() 
Dec 13 04:24:50   File "test/run_test.py", line 449, in main 
Dec 13 04:24:50     raise RuntimeError(message) 
Dec 13 04:24:50 RuntimeError: test_nn failed! 
Dec 13 04:24:50 + cleanup 
Dec 13 04:24:50 + retcode=1 
Dec 13 04:24:50 + set +x 
Dec 13 04:24:50 =================== sccache compilation log =================== 
Dec 13 04:24:50 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Dec 13 04:24:50 Compile requests                 0 
Dec 13 04:24:50 Compile requests executed        0 
Dec 13 04:24:50 Cache hits                       0 
Dec 13 04:24:50 Cache misses                     0 
Dec 13 04:24:50 Cache timeouts                   0

pytorch_macos_10_13_py3_test (5/11)

Step: "Test" (details)

Dec 12 20:27:35 Ran 2292 tests in 137.627s 
Dec 12 20:27:35  
Dec 12 20:27:35 FAILED (errors=2, skipped=63, expected failures=1) 
Dec 12 20:27:35  
Dec 12 20:27:35 Generating XML reports... 
Dec 12 20:27:36 Traceback (most recent call last): 
Dec 12 20:27:36   File "test/run_test.py", line 456, in <module> 
Dec 12 20:27:36     main() 
Dec 12 20:27:36   File "test/run_test.py", line 449, in main 
Dec 12 20:27:36     raise RuntimeError(message) 
Dec 12 20:27:36 RuntimeError: test_jit failed! 
Dec 12 20:27:36 + cleanup 
Dec 12 20:27:36 + retcode=1 
Dec 12 20:27:36 + set +x

pytorch_linux_xenial_cuda9_cudnn7_py3_multigpu_test (6/11)

Step: "Test" (details)

Dec 13 04:55:33 [       OK ] ParallelTest.DataParallelUsesAllAvailableCUDADevices_CUDA (0 ms) 
Dec 13 04:55:33 [ RUN      ] ParallelTest.DataParallelNumericalEquivalence_MultiCUDA 
Dec 13 04:55:36 [       OK ] ParallelTest.DataParallelNumericalEquivalence_MultiCUDA (3378 ms) 
Dec 13 04:55:36 [----------] 9 tests from ParallelTest (7641 ms total) 
Dec 13 04:55:36  
Dec 13 04:55:36 [----------] Global test environment tear-down 
Dec 13 04:55:36 [==========] 786 tests from 32 test cases ran. (76253 ms total) 
Dec 13 04:55:36 [  PASSED  ] 784 tests. 
Dec 13 04:55:36 [  FAILED  ] 2 tests, listed below: 
Dec 13 04:55:36 [  FAILED  ] IntegrationTest.MNIST_CUDA 
Dec 13 04:55:36 [  FAILED  ] IntegrationTest.MNISTBatchNorm_CUDA 
Dec 13 04:55:36  
Dec 13 04:55:36  2 FAILED TESTS 
Dec 13 04:55:38 + cleanup 
Dec 13 04:55:38 + retcode=1 
Dec 13 04:55:38 + set +x 
Dec 13 04:55:38 =================== sccache compilation log =================== 
Dec 13 04:55:38 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Dec 13 04:55:38 Compile requests                 0 
Dec 13 04:55:38 Compile requests executed        0 
Dec 13 04:55:38 Cache hits                       0

pytorch_linux_xenial_cuda9_cudnn7_py3_nogpu_test (7/11)

Step: "Test" (details)

Dec 13 05:05:06 Ran 1473 tests in 466.414s 
Dec 13 05:05:06  
Dec 13 05:05:06 FAILED (errors=2, skipped=681, expected failures=2) 
Dec 13 05:05:06  
Dec 13 05:05:06 Generating XML reports... 
Dec 13 05:05:07 Traceback (most recent call last): 
Dec 13 05:05:07   File "test/run_test.py", line 456, in <module> 
Dec 13 05:05:07     main() 
Dec 13 05:05:07   File "test/run_test.py", line 449, in main 
Dec 13 05:05:07     raise RuntimeError(message) 
Dec 13 05:05:07 RuntimeError: test_nn failed! 
Dec 13 05:05:07 + cleanup 
Dec 13 05:05:07 + retcode=1 
Dec 13 05:05:07 + set +x 
Dec 13 05:05:07 =================== sccache compilation log =================== 
Dec 13 05:05:07 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Dec 13 05:05:07 Compile requests                  7 
Dec 13 05:05:07 Compile requests executed         6 
Dec 13 05:05:07 Cache hits                        0 
Dec 13 05:05:07 Cache misses                      6 
Dec 13 05:05:07 Cache timeouts                    0

pytorch_linux_xenial_cuda9_cudnn7_py3_NO_AVX2_test (8/11)

Step: "Test" (details)

Dec 13 05:07:44 Ran 1566 tests in 612.073s 
Dec 13 05:07:44  
Dec 13 05:07:44 FAILED (failures=1, errors=15, skipped=59, expected failures=4) 
Dec 13 05:07:44  
Dec 13 05:07:44 Generating XML reports... 
Dec 13 05:07:45 Traceback (most recent call last): 
Dec 13 05:07:45   File "test/run_test.py", line 456, in <module> 
Dec 13 05:07:45     main() 
Dec 13 05:07:45   File "test/run_test.py", line 449, in main 
Dec 13 05:07:45     raise RuntimeError(message) 
Dec 13 05:07:45 RuntimeError: test_nn failed! 
Dec 13 05:07:45 + cleanup 
Dec 13 05:07:45 + retcode=1 
Dec 13 05:07:45 + set +x 
Dec 13 05:07:45 =================== sccache compilation log =================== 
Dec 13 05:07:45 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Dec 13 05:07:45 Compile requests                32 
Dec 13 05:07:45 Compile requests executed       11 
Dec 13 05:07:45 Cache hits                       1 
Dec 13 05:07:45 Cache misses                    10 
Dec 13 05:07:45 Cache timeouts                   0

pytorch_linux_xenial_cuda9_cudnn7_py3_test (9/11)

Step: "Test" (details)

Dec 13 05:07:48 Ran 1566 tests in 602.670s 
Dec 13 05:07:48  
Dec 13 05:07:48 FAILED (failures=1, errors=15, skipped=59, expected failures=4) 
Dec 13 05:07:48  
Dec 13 05:07:48 Generating XML reports... 
Dec 13 05:07:49 Traceback (most recent call last): 
Dec 13 05:07:49   File "test/run_test.py", line 456, in <module> 
Dec 13 05:07:49     main() 
Dec 13 05:07:49   File "test/run_test.py", line 449, in main 
Dec 13 05:07:49     raise RuntimeError(message) 
Dec 13 05:07:49 RuntimeError: test_nn failed! 
Dec 13 05:07:49 + cleanup 
Dec 13 05:07:49 + retcode=1 
Dec 13 05:07:49 + set +x 
Dec 13 05:07:49 =================== sccache compilation log =================== 
Dec 13 05:07:49 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Dec 13 05:07:49 Compile requests                32 
Dec 13 05:07:49 Compile requests executed       11 
Dec 13 05:07:49 Cache hits                       1 
Dec 13 05:07:49 Cache misses                    10 
Dec 13 05:07:49 Cache timeouts                   0

pytorch_linux_xenial_cuda9_cudnn7_py3_NO_AVX_NO_AVX2_test (10/11)

Step: "Test" (details)

Dec 13 05:08:00 Ran 1566 tests in 607.655s 
Dec 13 05:08:00  
Dec 13 05:08:00 FAILED (failures=1, errors=15, skipped=59, expected failures=4) 
Dec 13 05:08:00  
Dec 13 05:08:00 Generating XML reports... 
Dec 13 05:08:00 Traceback (most recent call last): 
Dec 13 05:08:00   File "test/run_test.py", line 456, in <module> 
Dec 13 05:08:00     main() 
Dec 13 05:08:00   File "test/run_test.py", line 449, in main 
Dec 13 05:08:00     raise RuntimeError(message) 
Dec 13 05:08:00 RuntimeError: test_nn failed! 
Dec 13 05:08:01 + cleanup 
Dec 13 05:08:01 + retcode=1 
Dec 13 05:08:01 + set +x 
Dec 13 05:08:01 =================== sccache compilation log =================== 
Dec 13 05:08:01 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Dec 13 05:08:01 Compile requests                32 
Dec 13 05:08:01 Compile requests executed       11 
Dec 13 05:08:01 Cache hits                       1 
Dec 13 05:08:01 Cache misses                    10 
Dec 13 05:08:01 Cache timeouts                   0

pytorch_linux_xenial_cuda9_cudnn7_py3_slow_test (11/11)

Step: "Test" (details)

Dec 13 05:19:40 [ RUN      ] JitTest.ModuleConversion_CUDA 
Dec 13 05:19:40 [       OK ] JitTest.ModuleConversion_CUDA (1 ms) 
Dec 13 05:19:40 [ RUN      ] JitTest.Interp_CUDA 
Dec 13 05:19:40 [       OK ] JitTest.Interp_CUDA (1 ms) 
Dec 13 05:19:40 [----------] 74 tests from JitTest (3848 ms total) 
Dec 13 05:19:40  
Dec 13 05:19:40 [----------] Global test environment tear-down 
Dec 13 05:19:40 [==========] 74 tests from 1 test case ran. (3848 ms total) 
Dec 13 05:19:40 [  PASSED  ] 73 tests. 
Dec 13 05:19:40 [  FAILED  ] 1 test, listed below: 
Dec 13 05:19:40 [  FAILED  ] JitTest.DCE 
Dec 13 05:19:40  
Dec 13 05:19:40  1 FAILED TEST 
Dec 13 05:19:41 + cleanup 
Dec 13 05:19:41 + retcode=1 
Dec 13 05:19:41 + set +x 
Dec 13 05:19:41 =================== sccache compilation log =================== 
Dec 13 05:19:41 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/tmp/torch_extensions/test_compilation_error_formatting/main.cpp: In function \'int main()\':\n/tmp/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error: expected \';\' before \'}\' token\n int main() { return 0 }\n                       ^\n" } 
Dec 13 05:19:41  
Dec 13 05:19:41 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Dec 13 05:19:41 Compile requests               128

2 failures not recognized by patterns:

Job	Step	Status
^{caffe2_onnx_py3_6_clang7_ubuntu16_04_build}	^Build	New in PR
^{pytorch_linux_xenial_py3_6_gcc5_4_build}	^Build	New in PR

This comment was automatically generated by Dr. CI.
Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 8 times.

Fix .to operator to preserve strides when self should be returned

aadf4ad

[ghstack-poisoned]

Fix flake8 on "Fix .to operator to preserve strides when self sho…

79d00ad

…uld be returned" [ghstack-poisoned]

VitalyFedyunin added a commit that referenced this pull request Dec 13, 2019

Fix .to operator to preserve strides when self should be returned

7708419

ghstack-source-id: 2882cf9 Pull Request resolved: #31227

VitalyFedyunin closed this Dec 27, 2019

facebook-github-bot deleted the gh/VitalyFedyunin/102/head branch January 27, 2020 15:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `.to` operator to preserve strides when `self` should be returned#31227

Fix `.to` operator to preserve strides when `self` should be returned#31227
VitalyFedyunin wants to merge 2 commits intogh/VitalyFedyunin/102/basefrom
gh/VitalyFedyunin/102/head

VitalyFedyunin commented Dec 13, 2019 •

edited

Loading

Uh oh!

kostmo commented Dec 13, 2019 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

VitalyFedyunin commented Dec 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kostmo commented Dec 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CircleCI build failures summary

Detailed failure analysis

11 new failures recognized by patterns

caffe2_onnx_py2_gcc5_ubuntu16_04_test (1/11)

pytorch_linux_xenial_py2_7_9_test (2/11)

pytorch_xla_linux_xenial_py3_6_clang7_test (3/11)

pytorch_linux_xenial_py3_clang5_asan_test (4/11)

pytorch_macos_10_13_py3_test (5/11)

pytorch_linux_xenial_cuda9_cudnn7_py3_multigpu_test (6/11)

pytorch_linux_xenial_cuda9_cudnn7_py3_nogpu_test (7/11)

pytorch_linux_xenial_cuda9_cudnn7_py3_NO_AVX2_test (8/11)

pytorch_linux_xenial_cuda9_cudnn7_py3_test (9/11)

pytorch_linux_xenial_cuda9_cudnn7_py3_NO_AVX_NO_AVX2_test (10/11)

pytorch_linux_xenial_cuda9_cudnn7_py3_slow_test (11/11)

2 failures not recognized by patterns:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

VitalyFedyunin commented Dec 13, 2019 •

edited

Loading

kostmo commented Dec 13, 2019 •

edited

Loading